Skip to content

Bug 2084154 - #2802

Merged
dklawren merged 2 commits into
masterfrom
2084154
Oct 28, 2026
Merged

dklawren merged 2 commits into
masterfrom
2084154

Conversation

@dklawren

Copy link
Copy Markdown
Collaborator

Review carried over from private pull request
https://bugzilla.mozilla.org/show_bug.cgi?id=2084154

Copilot AI balanced review requested due to automatic review settings October 28, 2026 20:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the hash-token validation hardening.

No open issues 🎉

What changed in this PR

Hardens Bugzilla’s hash-token validation against field-shifting forgeries by validating timestamps before regenerating tokens and sharing token-format parsing with CGI login.

Changes:

  • Requires ASCII numeric timestamps and adds a shared hash_token_time parser.
  • Adds regression tests for forged tokens, malformed input, and valid token round-trips.
  • Removes a leftover patch-reject file.
File Description
t/​hash-token.t Adds hash-token validation and forgery regression tests.
Bugzilla/​Token.pm Validates issuance timestamps and centralizes token-format parsing.
Bugzilla/​Auth/​Login/​CGI.pm Uses the shared parser before regenerating login tokens.
Bugzilla/​API/​V1/​Github.pm.rej Deletes a leftover patch-reject artifact.

Review effort: Balanced

@dklawren
dklawren merged commit afa40b3 into master Oct 28, 2026
7 checks passed
@dklawren
dklawren deleted the 2084154 branch October 28, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants