Skip to content

feat: cross-promo block in the waitlist confirm email - #151

Merged
ralyodio merged 2 commits into
masterfrom
feat/cross-promo
Nov 11, 2026
Merged

ralyodio merged 2 commits into
masterfrom
feat/cross-promo

Conversation

@ralyodio

Copy link
Copy Markdown
Collaborator

Appends the shared "more from the network" block from @profullstack/cross-promo (audience developers) to the waitlist double opt-in email.

  • Placed outside and below the card holding the confirm button and paste-link, so it never competes with the confirm action; in the text part it comes after the confirm link.
  • Sender = the tenant domain from ?dn= (default moshcoding.com); moshcoding.com is always excluded too.
  • Dark theme matching the template. promoBlock never throws and falls back to the bundled catalog if the CDN is down.
  • New tests/waitlist-promo.test.mjs: block present, after the confirm button and link, never promotes the sender (also for a tenant on a catalog property).

🤖 Generated with Claude Code

Appends the shared "more from the network" block (@profullstack/cross-promo,
audience developers) to the waitlist double opt-in email, outside and below
the card with the confirm button and link so it never competes with the
confirm action; the text part puts it after the confirm link too. The sender
is the tenant domain (?dn=), and moshcoding.com is always excluded. Never
throws, and falls back to the bundled catalog when the CDN is down.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@socket-security

socket-security Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​profullstack/​cross-promo@​0.1.0751008990100

View full report

@github-actions

Copy link
Copy Markdown

ThreatCrush Security Scan

30 finding(s)

HIGH/CRITICAL: 2 | MEDIUM: 26 | LOW: 2

Severity Rule Location
HIGH sh-remote-script-execution public/install.sh:365
HIGH js-ssrf-outbound-request public/sw.js:5
MEDIUM js-open-redirect app/dashboard/[[...tab]]/page.tsx:68
MEDIUM js-open-redirect app/signup/page.tsx:51
MEDIUM js-unescaped-html-sink components/PitFooter.tsx:30
MEDIUM js-open-redirect components/PitSearch.tsx:118
MEDIUM js-unescaped-html-sink components/Tenant.tsx:30
MEDIUM js-unescaped-html-sink components/Tenant.tsx:31
MEDIUM js-unescaped-html-sink components/Tenant.tsx:79
MEDIUM js-unescaped-html-sink components/Tenant.tsx:155
MEDIUM sql-template-interpolation lib/db.ts:592
MEDIUM sql-template-interpolation lib/db.ts:1310
MEDIUM redos-nested-quantifier lib/markdown.ts:109
MEDIUM sql-template-interpolation lib/webhook-store.ts:95
MEDIUM sql-template-interpolation lib/webhook-store.ts:102
MEDIUM sql-template-interpolation lib/webhook-store.ts:108
MEDIUM sql-template-interpolation lib/webhook-store.ts:111
MEDIUM sql-template-interpolation lib/webhook-store.ts:116
MEDIUM sql-template-interpolation lib/webhook-store.ts:117
MEDIUM sql-template-interpolation lib/webhook-store.ts:121
MEDIUM sql-template-interpolation lib/webhook-store.ts:128
MEDIUM sql-template-interpolation lib/webhook-store.ts:133
MEDIUM sql-template-interpolation lib/webhook-store.ts:144
MEDIUM sql-template-interpolation lib/webhook-store.ts:154
MEDIUM sql-template-interpolation lib/webhooks.ts:207
MEDIUM sh-remote-script-execution public/install.sh:124
MEDIUM sh-remote-script-execution public/install.sh:128
MEDIUM sh-remote-script-execution public/install.sh:147
LOW secret-generic-credential tests/signup-profile.test.mjs:28
LOW secret-generic-credential tests/signup-profile.test.mjs:39

Snippets are redacted; ThreatCrush never prints matched credential material.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ralyodio
ralyodio merged commit 521680a into master Nov 11, 2026
5 checks passed
@ralyodio
ralyodio deleted the feat/cross-promo branch November 11, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant