Repository navigation
Preserve equals signs in query filter values - #61
Open
harbinresearcher wants to merge 1 commit into
Open
harbinresearcher wants to merge 1 commit into
harbinresearcher wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #60.
The CLI query tool rejects filter values containing equals signs, even though
query_app()matches the same string. For example, a directive registered withname='https://example.test/?q=python'cannot be selected withdecq foo 'name=https://example.test/?q=python': splitting on every=raisesToolError: Cannot parse query filter, no =..Split at the first equals sign and retain the remainder as the value. Keep whitespace stripping, missing-separator errors and the conversion/matching pipeline. Add a query-tool docstring note, changelog entry, seven parsing cases, and a public CLI regression checking both the matching and nonmatching registrations. All eight new cases fail before the fix.
Validation:
tox -e py311,py314,coverage,lint,docs,mypy,pyright: full tests, 100% statement coverage, Ruff check/format, strict Sphinx HTML/doctests, and the configured 3.11-3.15 targets of both type checkers.test_error.py: those assertions expect/test_error.pybut Windows reports backslashes. Failure identities were compared; configured statement coverage is100% on both trees. No claim that the Windows full suite passes.PyPy, macOS, and the remaining runtime matrix were not run locally. This is a reproduction using ordinary string attributes, with no downstream production-incident claim.
Disclosure: investigation, implementation, testing, and independent review were performed autonomously with AI under the contributor's authorization. Maintainer review is still needed.