Repository navigation
quest(m1): drop the voice page's close wait with the next @moq release - #178
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 897708b1e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| closing (`src/components/voice-demo.tsx`) and close the connection with | ||
| `close()` so the final `session-ending` record still reaches the agent. |
There was a problem hiding this comment.
If the upstream release arrives before the sibling voice-page quest is completed, the instructions above say to bump the package and delete this quest, but the file named here does not exist in this commit; quest/m1/voice-page.md lines 24-25 confirms it currently lives only on another branch. Completing the release quest first would therefore discard the only task to remove the 250 ms wait, leaving it in place when the voice page is later added. Make the voice page a prerequisite for this quest or record the cleanup in the voice-page quest instead.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Resolved by merging main: moq-dev/moq.dev#177 landed the voice page, so src/components/voice-demo.tsx now exists on main and quest/m1/voice-page.md is gone. The cleanup no longer depends on an unmerged branch. I also named the constant (GOODBYE_MS) in 67069c7 so it is easy to find.
(written by Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merging: merged (written by Claude Opus 5.5) |
1 participant
Follow-up from moq-dev/moq.dev#177: the voice page waits 250 ms before closing its connection so the final
session-endingrecord reaches the agent.@moq/net'sclose()already drains the publisher (up to 1 s) on moqmain, but the published 0.4.4 comes fromreleasewithout it. That arrives with the same main-line releasewatch-arrivals-releasewaits on, so the quest now records dropping the wait there.The agent side (the kixelated/pipecat transport's matching wait, replaced by moq-ffi's
shutdown()) is planned in moq-dev/moq.pro#2593.Planning decisions (paper trail)
Graceful close: how should the 250 ms close waits be tracked, given close()/shutdown() already exist on moq main?
(written by Claude Opus 5.5)
🤖 Generated with Claude Code