Repository navigation
Mark only the Jira keys a change does not mention - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#53 put
named,linkedornamed, linkednext to every Jira key on a row. Feedback: the labels weren't clear and made the column noisy. The words come from the report model, and the common case, where a merge request mentions its own key, doesn't need explaining.Changes:
via Jira. Hovering explains it, e.g. "Not mentioned in !54. SHOP-33 links to it in Jira."viaNamed,viaLinkedandviaTitlestrings are replaced byviaJiraandviaJiraTitle, in English and Russian.docs/page.mddescribes the marker.The report is unchanged; this only reads
via.Tests:
test_demo_only_a_key_the_change_does_not_mention_is_marked_as_via_jirareplaces the named/linked test. It checks that only SHOP-33 on !54 is marked, the hover text, and that a mentioned key has no marker. It failed before the change.just lint-ci,just test-ciandjust test-smokepass.