Repository navigation
docs: note telemetry cost and OTel sampling env vars - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Telemetry cost" paragraph to AGENTS.md next to pool and server sizing.
Numbers come from a benchmark of this template in Docker on Linux: Granian with 1 worker and 2 CPUs, Postgres 17, oha at 32 connections, OTel exporting over gRPC to a real collector, Sentry pointed at a dummy endpoint. Medians of 3 x 10 s runs over 2 rounds:
parentbased_traceidratio0.1The OTel and Sentry together row comes from an earlier run with the same setup.
A py-spy profile under load shows where the time goes. OTel spends it in span creation in the SDK, in the OTLP exporter thread, and in the ASGI middleware (
collect_request_attributes, the wrappedsend). The middleware runs on unsampled requests too. Sentry, withtraces_sample_rateunset, still runsstart_transaction,continue_traceand a span per middleware through_create_span_callon every request.No code change: the SDK already reads
OTEL_TRACES_SAMPLERandOTEL_TRACES_SAMPLER_ARG, because lite-bootstrap passes no sampler.