Repository navigation
docs: drop the unconditional no-op claim from the broker.publish docstring - #261
Merged
Merged
Conversation
Benchmark gate✅ gate passed
Gated (fails the build): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
broker.publishdocstring still said that re-publishing atimer_id"is a no-op (returns None)". That was true beforetimer_conflictexisted. Undertimer_conflict="extend"it is wrong, because an unleased timer is updated and the call returns its id. The next paragraph of the docstring already describes both modes correctly, so the timer_id sentence now points to it instead of contradicting it.OutboxPublisher.publishandOutboxResponsewere updated in #254 and need no change.Checklist
ruff format --checkandruff checkpass onbroker.py;tests/test_unit.pyandtests/test_fake.pypass (461).