Repository navigation
Add missing each to array attributes of Media.Common.ThermoFluidSpecial records - #4852
Open
hubertus65 wants to merge 1 commit into
Open
hubertus65 wants to merge 1 commit into
hubertus65 wants to merge 1 commit into
Conversation
ThermoBaseVars and ThermoProperties declare 24 arrays with scalar min, max
and nominal modifiers but without each, which OpenModelica rejects. The rates
dZ and rZ of ThermoBaseVars also had nominal=0, which Modelon Impact rejects
("A nominal value of zero is not meaningful"); use nominal 1.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UmNZkRw6HV9CeBvNk36AzT
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modelica.Media.Common.ThermoFluidSpecial.ThermoBaseVarsandThermoPropertiesdeclare arrays with scalar attribute modifiers but withouteach. For example:A scalar modifier of an array element attribute needs
each. OpenModelica rejects both records when they are instantiated:This PR adds
eachtomin,maxandnominalof all 24 affected declarations: 19 in ThermoBaseVars and 5 in ThermoProperties.It also changes the nominal values of the rates
dZandrZin ThermoBaseVars. Both declarednominal=0.0, which Modelon Impact (OCT) rejects in a copy of the record (it accepts the read-only MSL 4.1.0 it ships):Both now use
each nominal=1.0, like the other rates and mole numbers of the record (MDOTNOM,MOLNOM).Verification
The test model fills both records from IF97 water properties: a ThermoProperties record and a two-cell ThermoBaseVars record.
each)nominalof zero)Nothing else in the MSL uses these records; they are covered by the new ModelicaTest test
ModelicaTest.Media.ThermoFluidSpecialRecordson branchcoverage-improvement.🤖 Generated with Claude Code
https://claude.ai/code/session_01UmNZkRw6HV9CeBvNk36AzT