Repository navigation
Add missing each to displayUnit of arg_u/arg_y in FromSymmetricalComponents - #4845
Open
hubertus65 wants to merge 1 commit into
Open
hubertus65 wants to merge 1 commit into
hubertus65 wants to merge 1 commit into
Conversation
…onents
Modelica.Electrical.QuasiStatic.Polyphase.Blocks.FromSymmetricalComponents
modified the array components arg_u[m] and arg_y[m] with a scalar
displayUnit="deg" without each. OpenModelica rejects the block ("Non-array
modification '"deg"' for array component 'displayUnit', possibly due to
missing 'each'").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modelica.Electrical.QuasiStatic.Polyphase.Blocks.FromSymmetricalComponentsmodifies the array outputsarg_u[m]andarg_y[m]with a scalardisplayUnit="deg"but noeach:OpenModelica 1.27.1 rejects the block:
This PR adds the missing
eachto both declarations. A scan ofModelicaandModelicaTestfound no other array attribute modifications of this form.Found while writing new ModelicaTest coverage tests. After the change, a test model instantiating the block passes
checkModelin OpenModelica.🤖 Generated with Claude Code