Repository navigation
fix: space conformance progress notifications - #329
Merged
jeanmatthieu merged 1 commit intoNov 10, 2026
Merged
jeanmatthieu merged 1 commit into
jeanmatthieu merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The shared conformance server sends progress notifications 50 microseconds apart, while the conformance scenario expects about 50 milliseconds. The test can receive only one or two notifications before the tool result. I reproduced this on
main, so this is separate from #307. This changes the two fixture delays to 50 milliseconds.How Has This Been Tested?
main, the progress scenario failed 2 of 5 runs. With this change, it passed 10 of 10 runs with all three notifications.swift test: 580 passed.scripts/run-conformance.sh --mode server: 47 passed, 0 failed.Breaking Changes
None. This only changes the conformance server fixture.
Types of changes
Checklist
Additional context
reviewed the diff and ran the tests.