Repository navigation
Conversation
varun06
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When repeated empty reads find a failed connection, the receive loop cancels it but leaves the transport connected. Heartbeats can keep sending after the socket closes. This also caused the macOS CI failure seen on #307.
Mark the transport disconnected and cancel its heartbeat task in that path. The new test covers the empty-read failure and checks that sends are rejected and heartbeats stop.
Tests: the new test failed on unchanged
main(19 sends after cancellation). All 18 network tests and the full 580-test suite passed with the fix onc0ff1e6. AI helped write the new test; I ran it.