Repository navigation
Conversation
ioConn.Write serialized writers with a mutex and checked ctx only before waiting for it, so a write whose context was canceled while another write was in progress still waited for that write and was then sent anyway. A write blocked on a peer that stopped reading could not be interrupted at all. Queue writers on a one-slot channel so a canceled waiter returns without sending. Canceling the active write closes the connection: bytes already handed to the stream cannot be withdrawn, and a partial frame would corrupt every later message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
missing-issue-link
github-actions
Bot
removed
the
missing-issue-link
Contributor
|
@Tangerg let's scope this PR only to the blocking case. Exclude for now the case of the cancellation of on going call |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ioConn.Writeserialized writers with a mutex and checked ctx only before waiting for it, so a write canceled while another write was in progress still waited and was then sent anyway, and a write blocked on a peer that stopped reading could not be interrupted.Writers now queue on a one-slot channel, so a canceled waiter returns
ctx.Err()without sending. Canceling the write in progress closes the connection: bytes already handed to the stream cannot be withdrawn, and a partial frame would corrupt every later message.Fixes #1498
AI assistance: prepared with Claude; I reviewed the change and can explain it.