Repository navigation
Raise Python floor to >=3.10; modernize annotations - #32
Merged
Merged
Conversation
setup.py python_requires, README (x2), and the conda recipe move from >=3.6 to >=3.10. With the floor at 3.10, the binding's runtime-evaluated annotations can use the PEP 585/604 spellings: __init__.py modernized by ruff autofix (UP006 x4, UP045 x18), the stale typing imports removed, and the UP006/UP045 global ruff opt-outs deleted — ruff.toml now has no global opt-outs, only the vendored-file per-file scoping. target-version pinned to py310 in ruff.toml so lint tracks the declared floor. Verified: ruff 0.17.2 check/format clean; test/test_gri.py 11 passed under Python 3.12; the package imports and connects under a real CPython 3.10.22 (annotations evaluate at import).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the Python binding's declared floor from >=3.6 to >=3.10 (setup.py
python_requires, both README requirements lines, and the conda recipe), per the maintainer's D5 ruling.With the floor at 3.10, the binding's runtime-evaluated annotations can use the PEP 585/604 spellings.
__init__.pyis modernized accordingly (ruff autofix: UP006 ×4, UP045 ×18; the now-unusedtyping.Dict/Optionalimports and the stale UP035 noqa are removed), and the UP006/UP045 global ruff opt-outs are deleted —ruff.tomlnow has no global opt-outs, only the vendored-file per-file scoping.target-version = "py310"is pinned inruff.tomlso lint tracks the declared floor.Verification: ruff 0.17.2 check + format clean (pre-commit hooks pass);
test/test_gri.py11 passed under Python 3.12; the package imports and connects under a real CPython 3.10.22, so the modernized annotations evaluate at the new floor.Note: the connector push resets
__init__.pyto mode 100644 (it cannot set exec bits); a brief follow-up chmod commit restores 100755, and CI lint shows EXE001 until it lands.