Skip to content

refactor: centralize virtue button authorization #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkmccarty merged 1 commit into from
Nov 14, 2026
Merged

refactor: centralize virtue button authorization #3313

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/virtue/virtue_all.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,19 @@ import (

const virtueAllPageSize = 15

func canControlVirtueTarget(callerID, targetUserID string, e *dc.ComponentEvent) bool {
if callerID == targetUserID {
return true
}
if altController := farmerstate.GetMiscSettingString(targetUserID, "AltController"); altController != "" && callerID == altController {
return true
}
if farmerstate.IsActAsLinked(callerID, targetUserID) {
return true
}
return farmerstate.GetEffectiveUserID(callerID, e.MessageID(), e.ChannelID()) == targetUserID
}

// HandleVirtueDismiss removes the action row buttons from the virtue display.
func HandleVirtueDismiss(e *dc.ComponentEvent) {
parts := strings.Split(e.CustomID(), "#")
Expand All @@ -23,8 +36,7 @@ func HandleVirtueDismiss(e *dc.ComponentEvent) {
}
targetUserID := parts[1]
callerID := e.UserID()
altController := farmerstate.GetMiscSettingString(targetUserID, "AltController")
if callerID != targetUserID && (altController == "" || callerID != altController) {
if !canControlVirtueTarget(callerID, targetUserID, e) {
_ = e.Respond(dc.Message{
Ephemeral: true,
Content: "Only the original caller can use this button.",
Expand Down Expand Up @@ -52,8 +64,7 @@ func HandleVirtueRefresh(e *dc.ComponentEvent) {
targetTE, _ := strconv.ParseUint(parts[3], 10, 32)

callerID := e.UserID()
altController := farmerstate.GetMiscSettingString(targetUserID, "AltController")
if callerID != targetUserID && (altController == "" || callerID != altController) {
if !canControlVirtueTarget(callerID, targetUserID, e) {
_ = e.Respond(dc.Message{
Ephemeral: true,
Content: "Only the original caller can use this button.",
Expand Down Expand Up @@ -118,8 +129,7 @@ func HandleVirtueShowAll(e *dc.ComponentEvent) {
isNav := len(parts) >= 6 && parts[5] == "nav"

callerID := e.UserID()
altController := farmerstate.GetMiscSettingString(targetUserID, "AltController")
if callerID != targetUserID && (altController == "" || callerID != altController) {
if !canControlVirtueTarget(callerID, targetUserID, e) {
_ = e.Respond(dc.Message{
Ephemeral: true,
Content: "Only the original caller can use this button.",
Expand Down
Loading