Repository navigation
fix(exports): define __all__ in msgraph/__init__.py and fix typo in README - #1604
Open
Hardik K (hardikkaurani) wants to merge 1 commit into
Open
Hardik K (hardikkaurani) wants to merge 1 commit into
Hardik K (hardikkaurani) wants to merge 1 commit into
Conversation
Author
|
I've opened this PR to explicitly define The PR also includes a small typo fix in the README. Whenever you have a chance, could you please take a look? Thank you for your time! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
__all__inmsgraph/__init__.pycontaining__version__,GraphRequestAdapter, andGraphServiceClient.msgraphcontains apy.typedmarker (PEP 561 / PEP 484), static type checkers and IDEs (such as PyLance / VSCode / PyCharm / mypy) require re-exported package symbols to be listed in__all__to recognize them as public module exports without raisingreportPrivateImportUsagewarnings.README.mdsection 2.3 ("create a GraphServiceClient object").