Skip to content

Fix Windows package installation path handling - #739

Open
Nathan (hydraxman) wants to merge 1 commit into
mainfrom
security/windows-appx-path-binding
Open

Nathan (hydraxman) wants to merge 1 commit into
mainfrom
security/windows-appx-path-binding

Conversation

@hydraxman

Copy link
Copy Markdown
Member

Summary

  • Keep Windows package paths out of PowerShell source by binding the absolute path through a process-scoped environment variable.
  • Preserve existing installation switches, output handling, and timeout behavior, including for previously stored filenames.
  • Add regression coverage for special-character filenames and isolation between installations.

Validation

  • Targeted agent tests: 2 passed, 0 failures/errors/skips (JDK 11).
  • Agent main/test Checkstyle passed; git diff --check clean.
  • Independent patch review: approved, no significant findings.
  • No live Windows package installation was performed.

Based on main at 2b36292. Original working-directory changes are untouched.

Pass package paths through process-scoped environment data instead of interpolating them into PowerShell source. Add regressions for special-character paths and process isolation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: e7291365-62a1-4496-b850-b7b0ccdcf0f9

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant