Skip to content

[deps] Address depandabot issue 32 - #1496

Merged
Mark Hildebrand (hildebrandmw) merged 1 commit into
mainfrom
mhildebr/rand
Oct 19, 2026
Merged

Mark Hildebrand (hildebrandmw) merged 1 commit into
mainfrom
mhildebr/rand

Conversation

@hildebrandmw

@hildebrandmw Mark Hildebrand (hildebrandmw) commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

diskann-label-filter has a stale, unused Cargo.lock file that is triggering https://github.com/microsoft/DiskANN/security/dependabot/32/. This removes that lock file, lower-bounds the rand dependency in rfcs/00105-label-format-parser/Cargo.toml to 0.8.6, and executes cargo update in rfcs/00105-label-format-parser for good measure.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The broad dependency refresh needs compatibility validation before approval.

No open issues 🎉

What changed in this PR

Addresses Dependabot alert 32 by removing a stale lockfile and updating dependencies for the standalone label-format parser RFC.

Changes:

  • Removes the unused label-filter lockfile.
  • Raises the RFC’s minimum rand version to 0.8.6.
  • Refreshes the RFC’s locked dependencies.
File Description
rfcs/​00105-label-format-parser/​Cargo.toml Raises the rand minimum version.
rfcs/​00105-label-format-parser/​Cargo.lock Refreshes resolved dependency versions.
diskann-label-filter/​Cargo.lock Deletes the stale lockfile associated with the alert.

Review effort: Balanced

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.07%. Comparing base (7a8ed89) to head (f1ceb7d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
+ Coverage   91.03%   92.07%   +1.04%     
==========================================
  Files         586      586              
  Lines      119926   119926              
==========================================
+ Hits       109176   110424    +1248     
+ Misses      10750     9502    -1248     
Flag Coverage Δ
miri 92.07% <ø> (+1.04%) ⬆️
unittests 92.02% <ø> (+1.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hildebrandmw
Mark Hildebrand (hildebrandmw) merged commit 3dd38ea into main Oct 19, 2026
32 checks passed
@hildebrandmw
Mark Hildebrand (hildebrandmw) deleted the mhildebr/rand branch October 19, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants