Repository navigation
[deps] Address depandabot issue 32 - #1496
Merged
Merged
Conversation
Mark Hildebrand (hildebrandmw)
requested review from
a team
and
a balanced review from Copilot
October 19, 2026 16:03
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The broad dependency refresh needs compatibility validation before approval.
No open issues 🎉
What changed in this PR
Addresses Dependabot alert 32 by removing a stale lockfile and updating dependencies for the standalone label-format parser RFC.
Changes:
- Removes the unused label-filter lockfile.
- Raises the RFC’s minimum
randversion to 0.8.6. - Refreshes the RFC’s locked dependencies.
| File | Description |
|---|---|
rfcs/00105-label-format-parser/Cargo.toml |
Raises the rand minimum version. |
rfcs/00105-label-format-parser/Cargo.lock |
Refreshes resolved dependency versions. |
diskann-label-filter/Cargo.lock |
Deletes the stale lockfile associated with the alert. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1496 +/- ##
==========================================
+ Coverage 91.03% 92.07% +1.04%
==========================================
Files 586 586
Lines 119926 119926
==========================================
+ Hits 109176 110424 +1248
+ Misses 10750 9502 -1248
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Harsha Simhadri (harsha-simhadri)
approved these changes
Oct 19, 2026
Jack Moffitt (metajack)
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
diskann-label-filterhas a stale, unusedCargo.lockfile that is triggering https://github.com/microsoft/DiskANN/security/dependabot/32/. This removes that lock file, lower-bounds theranddependency inrfcs/00105-label-format-parser/Cargo.tomlto 0.8.6, and executescargo updateinrfcs/00105-label-format-parserfor good measure.