Repository navigation
feat(openmp): add OpenMP compatibility package and tests - #529
Merged
Merged
Conversation
# Conflicts: # README.md # README.zh-CN.md
# Conflicts: # README.md # README.zh-CN.md
# Conflicts: # README.md # README.zh-CN.md
Sunrisepeak
approved these changes
Oct 13, 2026
Sunrisepeak
left a comment
Sunrisepeak
left a comment
Member
There was a problem hiding this comment.
Reviewed the pinned LLVM source/hash and real runtime build, Unix static C ABI, Windows DLL/import-library pairing and deployment. The forwarding/fake _OPENMP header is gone; the consumer launches two threads and verifies a reduction. Missing compiler flags and missing runtime fail the independent negative checks. Local CI-pinned mcpp/GCC and direct Clang runtime tests pass; Linux default/LLVM, macOS and Windows CI all pass on this exact head. Windows batch execution preserves quoted paths, and the import-library fallback uses the same DLL link output. No unresolved review findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
compat.openmpand a consumer example resolved from this checkout.The follow-up review fixes descriptor identity/layout and validates actual library behavior. Source URLs are pinned and hashed; plain-string GLOBAL URLs retain the documented CN fallback. See
.agents/docs/2026-10-13-add-openmp-plan.mdfor build shape, feature assessment and validation.Builds the actual upstream LLVM libomp runtime with CMake (static on Unix, DLL/import library on Windows). The test launches two threads and checks a reduction; no fallback header fabricates
_OPENMP.