Repository navigation
Monitor_nD: support 1D x or y banks in Mantid mode - #2892
Merged
Merged
Conversation
Mantid's LoadMcStas requires 6 event columns (p x y n id t), so a 'mantid square' monitor binned only in x (or y) wrote 5 columns and Mantid silently loaded no events; 'y bins=1' was the workaround. - In mantid mode with a square monitor, add the missing x or y coordinate with a single bin spanning the monitor, keeping x before y. - MANTID_RECTANGULAR_DET now finds the x, y and pixel coordinates by type instead of assuming positions 1, 2 and 4, so 'y ... x' no longer gives a 90-degree rotated IDF. - mcdisplay-mantid: write xstart/ystart as the first pixel centre, as Mantid expects, instead of the bin edge (half-pixel shift, half the detector size in a 1-bin direction). Fixes #2178 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mantid's LoadMcStas requires 6 event columns (p x y n id t), so a 'mantid square' monitor binned only in x (or y) wrote 5 columns and Mantid silently loaded no events; 'y bins=1' was the workaround.
Fixes #2178
Free-form text area
Please describe what your PR is adding in terms of features or bugfixes:
Declaration of use of AI-tools
Development OS / boundary conditions
Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
PR Checklist for contributing to McStas/McXtrace
For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:
My contribution contains something else