Repository navigation
normed type neighborhood lemmas - #2030
Conversation
db98ac7 to
b8ceb1c
Compare
|
(not yet reviewed but rebased) |
|
The statement of See NB(2026-10-01): The comment pointed at has been addressed by PR #2112 |
|
The duplication of code is calling for a more in-depth review (which might end up in adding structures) so we postpone to the next release (fyi: @mkerjean ) |
|
I retract this comment because the setting is a bit different now that we are heading for getting rid of UniformLmodule (see PR #2112 ). |
|
I'm happy to do a review but I'm lacking a bit of context. Why are these lemmas duplicated ? What's the goal of this PR ? |
7f9b977 to
6508417
Compare
|
I can't find uses of |
6508417 to
4b82589
Compare
affeldt-aist
left a comment
There was a problem hiding this comment.
That looks ok. Lemmas seem reasonable but they lack context to be sure. For example, how are near_shiftE and nearZE used (I couldn't find in subsequent PRs)? Should the statement of near_shiftE rather be written like nbhsDl (<- vs. =)? Shouldn't them be renamed to have matching names (I think so: can you propose a preferred name?)? fyi: @mkerjean (this PR is loosely related to PR #2112 )
ping @nmolinamounier ? |
|
I was kind of surprised to realize some of these weren't used in my other PRs; chances are, they were used in some dead code that I later removed. As for usage, I don't really know how to describe it better than turning a goal of the form I think in my work it came up when working with derivatives : all of the relevant limits are stated around |
|
Would you consider removing (at least temporarily) the unused lemma from your PR? |
4b82589 to
096d123
Compare
affeldt-aist
left a comment
There was a problem hiding this comment.
All the lemmas look useful. Moreover, this PR has helped further motivate PR #2112.
Motivation for this change
Split from #2023. Depends on #2024 and #2027.
Checklist
CHANGELOG_UNRELEASED.mdadded corresponding documentation in the headersReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers