Repository navigation
add itv_closureE, itv_interiorE, and helper lemmas - #1848
Conversation
|
For the sake of making progress with this PR, couldn't the part about |
|
There a few lemmas in |
There was a problem hiding this comment.
This PR is definitely useful (as exemplified by PR #1910 which is a special case as you rightfully observed, sorry about the duplicate, my bad).
I made a couple of requests to split out a few things that look like they could be PRed independently. The goal is twofold.
On the one hand, additions to classical_sets.v, topology_structure.v can be merged quickly; the addition of setUitv2 might have the same issue as we had with setUitv1/setU1itv which can be solved by a naming discussion that could take a bit more time so an individual PR would help.
On the other hand, the main addition about endlessness and order-density still needs to be experimented using HB.mixin's (as we already discussed). I am confident it will work out great but in any case this is a substantial addition to unstable.v that will need to be backported to MathComp at some point. I think that reducing this PR to endlessness and order-density will have the advantage of making it clearer when doing the HB.mixin experiment and the backport.
What do you think?
|
Thanks for suggestions. I will separate some suggested parts into separate PRs. setUitv1 and setU1itv are PRed as #1864. I will add a short comment at closureEbigcap_itvcy, etc. about their use of Turning endless and dense orders into HB structures is a bigger change, Additionally, I want to generalize statements about closures a bit to Because of the last two points, I turn this PR into a draft for now. |
|
Is it ok for me to rebase this PR? |
bdf9839 to
02ec85b
Compare
affeldt-aist
left a comment
There was a problem hiding this comment.
The lemmas provided by this PR are definitely useful.
I find the way the formalization is carried out clever.
There is the pending question of using HB for endlessness and density.
This is deferred to a MathComp PR under review
(math-comp/math-comp#1597, @CohenCyril).
The impact of potential changes is properly mitigated by the use of modules.
Provided the code is revised with MathComp PR 1597 is merge, it is ok
for me to merge this PR for the time being.
@holgerthies , @IshiguroYoshihiro : you might want to take a look
Thanks a lot @t6s !
|
I forgot to merge this one. |
|
Looks okay. I am planning some additions, but they will be in another PR. |
be30766 to
11f6704
Compare
Motivation for this change
Reviewing PR #1674 , it was noticed that there is not much theory
connecting closure/interior operators and set-intervals.
This PR adds lemmas to amend that, especially
itv_interiorEanditv_closureEstating that the interior/closure of an interval is an open/closed interval respectively,
for intervals in
realFieldType.This should resolve the following comment:
https://github.com/math-comp/analysis/pull/1674/changes/BASE..34697b2642259157cd3678e64092864dcd0ca4ef#r2685444293
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers