Skip to content

add itv_closureE, itv_interiorE, and helper lemmas - #1848

Merged
affeldt-aist merged 5 commits into
math-comp:masterfrom
t6s:real_itv_open_ends
Oct 15, 2026
Merged

affeldt-aist merged 5 commits into
math-comp:masterfrom
t6s:real_itv_open_ends

Conversation

@t6s

@t6s t6s commented Feb 16, 2026 •

Copy link
Copy Markdown
Member
Motivation for this change

Reviewing PR #1674 , it was noticed that there is not much theory
connecting closure/interior operators and set-intervals.
This PR adds lemmas to amend that, especially itv_interiorE and itv_closureE
stating that the interior/closure of an interval is an open/closed interval respectively,
for intervals in realFieldType.

This should resolve the following comment:
https://github.com/math-comp/analysis/pull/1674/changes/BASE..34697b2642259157cd3678e64092864dcd0ca4ef#r2685444293

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@t6s
t6s requested a review from affeldt-aist February 16, 2026 10:12
@t6s t6s mentioned this pull request Feb 16, 2026
1 of 2 tasks
Comment thread classical/unstable.v Outdated
Comment thread classical/set_interval.v Outdated
Comment thread classical/unstable.v Outdated
@affeldt-aist

affeldt-aist commented Mar 20, 2026 •

Copy link
Copy Markdown
Member

For the sake of making progress with this PR, couldn't the part about classical_sets.v be a different PR? It looks pretty uncontroversial and could be merged quickly (this includes new lemmas and also the moving of the scope declarations for relations).

Comment thread classical/set_interval.v Outdated
@affeldt-aist

Copy link
Copy Markdown
Member

There a few lemmas in topology_structure.v (closureEbigcap_itvcy, interiorEbigcup_itvNyc, closureEbigcap_itvcc, interiorEbigcup_itvcc) that look like they could be PRed independently.
By the way, I was surprised to see that in these lemmas the variable A is used both as a set and
as an interval bound. Isn't that surprising and deserving a comment?

@affeldt-aist affeldt-aist left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is definitely useful (as exemplified by PR #1910 which is a special case as you rightfully observed, sorry about the duplicate, my bad).

I made a couple of requests to split out a few things that look like they could be PRed independently. The goal is twofold.

On the one hand, additions to classical_sets.v, topology_structure.v can be merged quickly; the addition of setUitv2 might have the same issue as we had with setUitv1/setU1itv which can be solved by a naming discussion that could take a bit more time so an individual PR would help.

On the other hand, the main addition about endlessness and order-density still needs to be experimented using HB.mixin's (as we already discussed). I am confident it will work out great but in any case this is a substantial addition to unstable.v that will need to be backported to MathComp at some point. I think that reducing this PR to endlessness and order-density will have the advantage of making it clearer when doing the HB.mixin experiment and the backport.

What do you think?

@t6s

t6s commented Mar 23, 2026

Copy link
Copy Markdown
Member Author

Thanks for suggestions.

I will separate some suggested parts into separate PRs.

setUitv1 and setU1itv are PRed as #1864.
There is an issue about an additional parameter, which will be discussed at #1914.

I will add a short comment at closureEbigcap_itvcy, etc. about their use of
intervals in powerset lattices.

Turning endless and dense orders into HB structures is a bigger change,
but necessary at some point in completing this PR.
I will PR it first to math-comp.

Additionally, I want to generalize statements about closures a bit to
handle also extended reals.

Because of the last two points, I turn this PR into a draft for now.

@t6s
t6s marked this pull request as draft March 23, 2026 00:53
@affeldt-aist

Copy link
Copy Markdown
Member

Is it ok for me to rebase this PR?

@affeldt-aist
affeldt-aist marked this pull request as ready for review September 30, 2026 07:47
@affeldt-aist
affeldt-aist self-requested a review September 30, 2026 07:47

@affeldt-aist affeldt-aist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lemmas provided by this PR are definitely useful.
I find the way the formalization is carried out clever.
There is the pending question of using HB for endlessness and density.
This is deferred to a MathComp PR under review
(math-comp/math-comp#1597, @CohenCyril).
The impact of potential changes is properly mitigated by the use of modules.
Provided the code is revised with MathComp PR 1597 is merge, it is ok
for me to merge this PR for the time being.

@holgerthies , @IshiguroYoshihiro : you might want to take a look

Thanks a lot @t6s !

@affeldt-aist affeldt-aist added this to the 1.19.0 milestone Oct 15, 2026
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Oct 15, 2026
@affeldt-aist

Copy link
Copy Markdown
Member

I forgot to merge this one.
@t6s is it still ok with you? (I mean, despite the draft PR math-comp/math-comp#1597)

@t6s

t6s commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Looks okay. I am planning some additions, but they will be in another PR.

@affeldt-aist
affeldt-aist merged commit 33339a9 into math-comp:master Oct 15, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement ✨ This issue/PR is about adding new features enhancing the library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants