Repository navigation
Release the storage of messages deleted for good - #8
Merged
Merged
Conversation
POST /fmsgid/send/release and /fmsgid/recv/release record types 4 and 3, which take a size off sendSizeTotal and recvSizeTotal (never below 0) but not off the daily usage, so deleting messages does not raise a daily limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An API that deletes a message for good needs to give the storage back to the sender's and recipients' quotas.
POST /fmsgid/send/releaseandPOST /fmsgid/recv/release, with the sameAddressTxbody and responses as/fmsgid/sendand/fmsgid/recv. They recordaddress_txrows of type 4 (send released) and 3 (recv released).sendSizeTotalandrecvSizeTotalnow subtract releases, never going below 0. The daily size and count windows still count only sends and receives, so deleting messages can't be used to get round a daily limit.dd.sqltype comment are updated. There's no schema change.Test:
TestAddressDetail_Releasechecks totals go down, the daily usage doesn't, and a release larger than the usage stops at 0. All tests pass against Postgres 17.🤖 Generated with Claude Code