Repository navigation
Sync DD scripts with fmsgd, fmsgid and fmsg-webapi main (trash) - #25
Merged
Merged
Conversation
fmsg-webapi main now stores each address's trash (fmsg_api_trash and fmsg_api_trash_state), and every message read queries it, so the stack's copy without them answered 500 on drafts, replies, reads and events. fmsgd's copy gains the fmsg.purge escape in its delete guard that trash's delete for good relies on; fmsgid's is a comment change. Generated with scripts/update-dd.sh from each repo's main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
markmnl
marked this pull request as ready for review
October 22, 2026 05:35
markmnl
enabled auto-merge (squash)
October 22, 2026 05:35
markmnl
disabled auto-merge
October 22, 2026 05:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fmsg-webapi
mainmerged Trash (markmnl/fmsg-webapi#56). Every message read now queriesfmsg_api_trash. This stack builds fmsg-webapi frommainbut initialized the database from a copy of itsdd.sqlthat predates the table. So the Web API answered 500 (relation "fmsg_api_trash" does not exist): drafts got "failed to validate pid", and reads, threads and WebSocket events got "failed to retrieve message". 14 of 15 scenarios failed, which broke fmsg-mcp'sfmsg-docker acceptanceCI on markmnl/fmsg-mcp#24, #25 and #26.This PR regenerates all three copies with
FMSGD_PATH= FMSGID_PATH= FMSG_WEBAPI_PATH= scripts/update-dd.sh, from each repo's GitHubmain:003-fmsg-webapi-dd.sql: adds thefmsg_api_trashtable and thefmsg_api_trash_statefunction.002-fmsgd-dd.sql: adds thefmsg.purgeescape in the delete guard, which Trash's "delete for good" relies on.002-fmsgid-dd.sql: a comment change.No permissions change is needed:
999-permissions.sqlgrants on all tables after the DDL runs.Verified locally with podman by running fmsg-mcp's CI job against this branch (
FMSG_DOCKER_REF=sync-dd-trash bash .github/scripts/run-fmsg-docker-e2e.sh): all 15 scenarios pass, and fmsg-mcp's e2e suite passes 4/4.🤖 Generated with Claude Code