Repository navigation
Updated clang tidy config and did some fixes - #162
Merged
Merged
Conversation
Collaborator
Author
|
I have fixed some of the easy things found by clang-tidy, but it would be great if we get all of them fixed so that we can add clang-tidy in a way that the CI breaks if there is a problem, so we don't accidentally introduce new problems. |
kkaefer
previously approved these changes
Oct 14, 2026
| template <class Tp> | ||
| inline __attribute__((always_inline)) void DoNotOptimize(Tp const& value) { | ||
| asm volatile("" : : "r,m"(value) : "memory"); | ||
| asm volatile("" : : "r,m"(value) : "memory"); // NOLINT(portability-no-assembler) |
Member
There was a problem hiding this comment.
For older versions of Clang, we still need hicpp-no-assembler here.
kkaefer
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.