[bdovaz]

Description

If I try to pass AddOption to it, it doesn't work—it doesn't pass them to that method.

I used Copilot for this PR; I'm just mentioning that in case it matters.

Type of Change

• Bug fix
• New feature
• Breaking change
• Documentation update

Checklist

• My code follows the project's style guidelines
• I have performed a self-review of my code
• I have added tests that prove my fix/feature works
• New and existing unit tests pass locally
• I have updated the documentation if needed

Related Issues

Closes #

[manusoft]

This change will affect Ytdlp.Download, Fix that and PR again.

public async Task DownloadAsync(string url, CancellationToken ct = default, bool tuneProcess = true)
{
///
var argsList = BuildArguments(url);
var arguments = string.Join(" ", argsList.Select(EscapeArgument));

///
}

[bdovaz]

@manusoft Instead of closing it, we can resolve this in this same PR so we don't have to create another one. I can make changes to the same branch and PR.

[bdovaz]

This change will affect Ytdlp.Download, Fix that and PR again.

public async Task DownloadAsync(string url, CancellationToken ct = default, bool tuneProcess = true) { /// var argsList = BuildArguments(url); var arguments = string.Join(" ", argsList.Select(EscapeArgument));

/// }

DownloadAsync calls BuildArguments(url), and that method now calls the new BuildConnectionArguments() helper. The arguments passed to yt-dlp contain the same tokens as before. The only difference is order: --username/--password, Adobe Pass, AddOption options, and the special options (cookies, proxy, etc.) now come before --paths, -o, -f, and the flags, instead of after them. yt-dlp doesn't depend on that order for these options, so download behavior is unchanged.

DownloadAsync itself needed no change, and it already passed auth and adobePass to the runner. I haven't edited any files for this.

@manusoft Can you explain what “This change will affect Ytdlp.Download” means?

[manusoft]

#96 Implemented the function by adding new BuilderProbeArgument(string url) private method. And also you cannot use BuilderArgument directly because it contains unwanted arguments for probe fuctionality, like --ffmpeg-location etc.
Any way thanks you for valuable contribution, I mention you in this PR.

[bdovaz]

No problem, thanks!