Skip to content

feat(jdbc): reject unsupported types and unlisted conversions #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
magnusp wants to merge 4 commits into from
Closed

feat(jdbc): reject unsupported types and unlisted conversions #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb72ef6
feat(jdbc): record n/a types and table b-6 getter support
magnusp Oct 25, 2026
ec28549
feat(jdbc): reject unsupported reads and unlisted getter conversions
magnusp Oct 25, 2026
2677afb
feat(jdbc): reject unsupported setobject targets
magnusp Oct 25, 2026
068e91d
test(jdbc): assert n/a rows against sqld
magnusp Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 63 additions & 2 deletions libsql-itests/src/test/java/com/github/magnusp/libsql/itest/Jdbc4AppendixBTypeMappingIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.sql.ResultSet;
import java.sql.RowId;
import java.sql.SQLException;
import java.sql.SQLFeatureNotSupportedException;
import java.sql.SQLXML;
import java.sql.Statement;
import java.sql.Struct;
Expand Down Expand Up @@ -51,6 +52,7 @@
import java.util.stream.Stream;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.junit.jupiter.api.Assertions.assertAll;
import static org.junit.jupiter.api.Assertions.fail;

Expand Down Expand Up @@ -140,6 +142,17 @@ private static JdbcType jdbc(
return new JdbcType(name, sqlType, b1, b3, sample);
}

/** The N/A policy: these declared and target types throw SQLFeatureNotSupportedException. */
private static final Set<String> NA_TYPES =
Set.of("ARRAY", "STRUCT", "REF", "JAVA_OBJECT", "DISTINCT");

private static final Set<Integer> NA_TARGETS =
Set.of(Types.ARRAY, Types.STRUCT, Types.REF, Types.JAVA_OBJECT, Types.DISTINCT);

/** The Table B-2/B-4 Java object types that map to an N/A JDBC type. */
private static final Set<String> NA_VALUES =
Set.of("java.sql.Array", "java.sql.Struct", "java.sql.Ref", "Java class");

interface SqlRead {
Object read(ResultSet resultSet, int column) throws SQLException;
}
Expand Down Expand Up @@ -190,7 +203,11 @@ void b1AndB3ReadPathAgainstRealDdl(JdbcType type) throws SQLException {
"CREATE TABLE " + table + " (v \"" + type.name() + "\")");
try (PreparedStatement insert =
connection.prepareStatement("INSERT INTO " + table + " (v) VALUES (?)")) {
insert.setObject(1, type.sample());
if (NA_TYPES.contains(type.name())) {
insert.setString(1, String.valueOf(type.sample()));
} else {
insert.setObject(1, type.sample());
}
insert.executeUpdate();
}
try (Statement query = connection.createStatement();
Expand All @@ -200,6 +217,16 @@ void b1AndB3ReadPathAgainstRealDdl(JdbcType type) throws SQLException {
.as("server reported declared type for %s", type.name())
.isEqualTo(type.name());

if (NA_TYPES.contains(type.name())) {
assertThatThrownBy(() -> NATURAL_GETTER.get(type.name()).read(resultSet, 1))
.as("B-1: %s is N/A", type.name())
.isInstanceOf(SQLFeatureNotSupportedException.class);
assertThatThrownBy(() -> resultSet.getObject(1))
.as("B-3: %s is N/A", type.name())
.isInstanceOf(SQLFeatureNotSupportedException.class);
return;
}

List<Executable> checks = new ArrayList<>();
checks.add(() -> {
Object natural;
Expand Down Expand Up @@ -285,6 +312,12 @@ void b6GetterReadsRecommendedTypeFromRealDdl(GetterCell cell) throws SQLExceptio
try (Statement query = connection.createStatement();
ResultSet resultSet = query.executeQuery("SELECT v FROM " + table)) {
assertThat(resultSet.next()).isTrue();
if (NA_TYPES.contains(cell.declaredType())) {
assertThatThrownBy(() -> cell.reader().read(resultSet, 1))
.as("B-6: %s on %s is N/A", cell.getter(), cell.declaredType())
.isInstanceOf(SQLFeatureNotSupportedException.class);
return;
}
Object value;
try {
value = cell.reader().read(resultSet, 1);
Expand Down Expand Up @@ -397,6 +430,12 @@ void b2StandardSettersMapJavaTypeToJdbcType(WriteRow row) throws SQLException {
statement.execute("CREATE TABLE " + table + " (v \"" + row.targetName() + "\")");
try (PreparedStatement insert =
connection.prepareStatement("INSERT INTO " + table + " (v) VALUES (?)")) {
if (NA_VALUES.contains(row.name())) {
assertThatThrownBy(() -> bindB2(insert, row))
.as("B-2: %s -> %s is N/A", row.name(), row.targetName())
.isInstanceOf(SQLFeatureNotSupportedException.class);
return;
}
try {
bindB2(insert, row);
} catch (SQLException e) {
Expand Down Expand Up @@ -537,6 +576,12 @@ void b4SetObjectMapsJavaObjectTypeToJdbcType(WriteRow row) throws SQLException {
statement.execute("CREATE TABLE " + table + " (v \"" + row.targetName() + "\")");
try (PreparedStatement insert =
connection.prepareStatement("INSERT INTO " + table + " (v) VALUES (?)")) {
if (NA_VALUES.contains(row.name())) {
assertThatThrownBy(() -> insert.setObject(1, row.value()))
.as("B-4: %s -> %s is N/A", row.name(), row.targetName())
.isInstanceOf(SQLFeatureNotSupportedException.class);
return;
}
insert.setObject(1, row.value());
insert.executeUpdate();
}
Expand Down Expand Up @@ -686,7 +731,16 @@ void b5SetObjectConvertsToExplicitTargetType(JavaRow row) throws SQLException {
+ placeholders + ")")) {
int parameter = 1;
for (Target target : TARGETS) {
if (row.targets().contains(target.sqlType())) {
if (row.targets().contains(target.sqlType())
&& NA_TARGETS.contains(target.sqlType())) {
int index = parameter;
assertThatThrownBy(
() -> insert.setObject(
index, sourceFor(row, target), target.sqlType()))
.as("B-5: %s -> %s is N/A", row.name(), target.name())
.isInstanceOf(SQLFeatureNotSupportedException.class);
insert.setNull(parameter++, target.sqlType());
} else if (row.targets().contains(target.sqlType())) {
insert.setObject(parameter++, sourceFor(row, target), target.sqlType());
} else {
insert.setNull(parameter++, target.sqlType());
Expand All @@ -708,6 +762,13 @@ void b5SetObjectConvertsToExplicitTargetType(JavaRow row) throws SQLException {
if (!row.targets().contains(target.sqlType())) {
continue;
}
if (NA_TARGETS.contains(target.sqlType())) {
checks.add(() -> assertThatThrownBy(
() -> readFor(target).read(resultSet, valueColumn))
.as("B-5: reading %s for %s is N/A", target.name(), row.name())
.isInstanceOf(SQLFeatureNotSupportedException.class));
continue;
}
checks.add(() -> {
Set<String> storage = storageOf(target.name());
if (!storage.isEmpty()) {
Expand Down
Loading
Loading