Repository navigation
fix(jdbc): read updateCount under the statement lock - #235
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #197
executeUpdatereturnedupdateCountwith a plain field read, outsidestateLock. Every write to that field happens inside asynchronized (stateLock)block, but the read afterexecutehad no happens-before edge, so a concurrentclose()orexecutecould hand back a stale count.Change
LibsqlStatement.snapshotUpdateCount(), which readsupdateCountunderstateLock.LibsqlStatement.executeUpdate(String)andLibsqlPreparedStatement.executeUpdate().This is a correctness fix, not a refactor.
getUpdateCount()already read the field understateLock; the two read paths now share the same lock discipline, soexecuteUpdateandgetUpdateCountcannot observe different values. There is nocheckClosed()in the new method: post-closeexecuteUpdatekeeps working, and the prepared statement already threw duringexecute.On the race
The race is hard to reproduce without instrumentation: the stale read is a memory-visibility gap, not a deterministic interleaving, and the field is a
longwritten under the lock. A test that tries to force it would be timing-dependent and flaky, so this PR does not add one. The argument is code-level:attachResult,discardCurrentResult,beginExecution,getMoreResults,executeBatch) are insidesynchronized (stateLock).snapshotUpdateCount()takes the same monitor before reading, which gives the read a happens-before edge to the last write and prevents a torn or stalelong.getUpdateCount()atLibsqlStatement:398already did exactly this; the fix makes the two paths consistent.No messages, post-close behavior, or update-count values change.
Verification
./mvnw testlibsql-jdbc(incl.LibsqlStatementConcurrencyTest, 7/7) + 35 codec, 0 failures./mvnw spotless:check./mvnw -pl libsql-conformance -am verifyDOCKER_CONFIG=... ./mvnw -pl libsql-itests -am verify