Repository navigation
Track shared potion cooldown - #11
Merged
Merged
Conversation
- data: add CreatePotionCooldown, one row in shared gear cooldowns - cooldowns: find potions in the bags by item class, no item IDs - cooldowns: follow the potion that was drunk, by its use spell - cooldowns: keep the last potion so a running cooldown stays shown - tooltip: show item tooltips for potion icons - dev, tests: label the potion row in dumps Closes #7
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows one icon for the shared potion cooldown, without listing potion item IDs.
Changes
data.CreatePotionCooldown(enabled)adds one potion row to the sharedgearcooldowns.BAG_UPDATE_DELAYED. It maps each potion's use spell to its item ID. A potion is any item with class Consumable / subclass Potion.UNIT_SPELLCAST_SUCCEEDED), the row switches to that item and reads its cooldown withC_Container.GetItemCooldown./filger dumpandtests/dump.lualabel the potion row.Tested
make checkandmake testpass.Not tested yet
SPELL_UPDATE_COOLDOWNfires on potion cooldowns. If it doesn't, these clients needBAG_UPDATE_COOLDOWN./reloadduring a running potion cooldown, the icon only returns after the next drink.Closes #7