Repository navigation
Conversation
Finalize now records unresolved spell IDs and duplicated cooldowns in
data.invalid as { kind, class, id } instead of printing a warning for
each one at every login. Cooldown rows are now validated for every
class, while the active list is still built from the player's class
and ALL only. With dev enabled, each invalid entry is printed on its
own line.
Prints the entries collected in data.invalid at load, grouped by kind and class, so spell data can be checked in-game on each client.
Name entries now hold a representative ID marked name; Finalize stores its localized name, so matching works on every locale. Drop the Retail name keys, which never matched.
A cast whose UNIT_SPELLCAST_SUCCEEDED spellID is secret is never recorded, so the row vanished once the restriction lifted while its cooldown was still running.
SPELL_UPDATE_COOLDOWN fires on every GCD, and each update built a new table per row and repeated the spell and item info lookups. Each row now keeps one data table that is refreshed in place. Spell name and icon are looked up again only when the override spell changes, since iconID follows the override. Slot name and icon are looked up again only when the equipped item link changes, and keep retrying while item info is not cached yet.
Covers FormatTime, the data constructors and Finalize (blacklist, spells, cooldown ordering, duplicates and invalid entries). Adds a make test target, runs it in CI and excludes tests/ from packaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FilgerDataSavedVariable./filger unseento list aura IDs that never appear; drop experimental commands.