Skip to content

tickets/SP-3085 add DP2 206.2 on deblender footprints - #225

Open
christinawilliams wants to merge 13 commits into
mainfrom
tickets/SP-3085
Open

christinawilliams wants to merge 13 commits into
mainfrom
tickets/SP-3085

Conversation

@christinawilliams

Copy link
Copy Markdown
Contributor

adding 206.2 tutorial notebook on deblender footprints

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@galaxyumi
galaxyumi self-requested a review October 14, 2026 21:40
@christinawilliams christinawilliams changed the title Tickets/sp 3085 adding DP2 206.2 on deblender footprints Oct 16, 2026
@christinawilliams christinawilliams changed the title adding DP2 206.2 on deblender footprints tickets/SP-3085 add DP2 206.2 on deblender footprints Oct 16, 2026
@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The link to DP2 is missing.
  • v30.0.10 -> r30.0.11

Please add:


Reply via ReviewNB

@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update section numbering to end with a period (e.g., '1.2.'). This comment applies to other sections, where relevant.


Reply via ReviewNB

@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description for parentObjectId is a bit confusing. How about "the unique ID of the object's parent blend" or something better?


Reply via ReviewNB

@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a brief explanation about why you're multiplying by 0.2?


Reply via ReviewNB

@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last sentence, "parentObjectId" -> "parentObjectId".


Reply via ReviewNB

@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool plot!


Reply via ReviewNB

@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the unit for intensity in the right column?


Reply via ReviewNB

@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of measurements you're referring to here? Could you be a bit more specific?


Reply via ReviewNB

@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'ie' -> 'i.e.,'

Also, can you add how the spectrum in Figure 6 was created then?


Reply via ReviewNB

@@ -0,0 +1,1095 @@
{

@galaxyumi galaxyumi Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The third panel is very dark. Is this showing what you wanted to show?


Reply via ReviewNB

@galaxyumi galaxyumi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Christina, this is a very helpful tutorial, but a bit difficult to follow. With a bit of rearranging and extra explanations, it will turn out to be great! I left some comments. Please let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants