Repository navigation
Conversation
This was referenced Mar 3, 2024
Pull Request Test Coverage Report for Build 8599495495Details
💛 - Coveralls |
aaqilniz
force-pushed
the
feat/strict-mode
branch
2 times, most recently
from
March 9, 2024 15:43
51066c4 to
13bf61a
Compare
aaqilniz
force-pushed
the
feat/strict-mode
branch
from
April 8, 2024 11:47
13bf61a to
7c08a93
Compare
aaqilniz
marked this pull request as ready for review
April 13, 2024 17:03
aaqilniz
marked this pull request as draft
October 25, 2026 10:19
aaqilniz
force-pushed
the
feat/strict-mode
branch
4 times, most recently
from
October 25, 2026 16:59
c9ad715 to
7621f00
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
aaqilniz
force-pushed
the
feat/strict-mode
branch
3 times, most recently
from
October 25, 2026 17:05
928e554 to
1565ba7
Compare
aaqilniz
marked this pull request as ready for review
October 25, 2026 17:19
aaqilniz
force-pushed
the
feat/strict-mode
branch
from
October 25, 2026 17:38
1565ba7 to
0ad1bb0
Compare
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
force-pushed
the
feat/strict-mode
branch
from
October 25, 2026 17:39
0ad1bb0 to
2b80a67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables
lb4 discoverto automatically detect database strict mode and injectjsonSchema.maxLengthalongside thelengthproperty, preventing unhandled database truncation errors.Purpose and Context
When the database is in strict mode and validation relies solely on model metadata length limits, requests exceeding column length fail with generic database errors.
Adding jsonSchema.maxLength ensures client-side validation catches data length violations before requests reach the database layer.
Related Issue:
jsonSchema.maxLengthalongsidelengthto support strict-mode validation loopback-next#11869Related PRs:
Checklist
npm testpasses on your machine