Skip to content

Add lstk to all the README pages where the reference was not listed in the prerequisites - #137

Merged
paolosalvatori merged 14 commits into
mainfrom
add-lstk
Oct 14, 2026
Merged

paolosalvatori merged 14 commits into
mainfrom
add-lstk

Conversation

@paolosalvatori

@paolosalvatori paolosalvatori commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

This pull requests adds lstk CLI reference in the prerequisites section in all the README files where the link was missing.

Fixes SMF-945

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Duplicate prerequisites, broken documentation links, and the unstated SQL EULA scope should be addressed.

12 open findings
What changed in this PR

Adds missing lstk CLI prerequisites across Azure samples and introduces SQL Server EULA setup guidance.

Changes:

  • Adds lstk CLI to 21 prerequisite sections.
  • Adds SQL Server EULA/configuration guidance to eight SQL sample guides.
  • Contains duplicate prerequisites and broken root-relative documentation links.
File Description
samples/​web-app-sql-database/​python/​terraform/​README.md Adds SQL EULA guidance.
samples/​web-app-sql-database/​python/​scripts/​README.md Adds SQL EULA guidance.
samples/​web-app-sql-database/​python/​README.md Adds prerequisite and EULA guidance.
samples/​web-app-sql-database/​python/​bicep/​README.md Adds SQL EULA guidance.
samples/​web-app-sql-database/​dotnet/​terraform/​README.md Adds SQL EULA guidance.
samples/​web-app-sql-database/​dotnet/​scripts/​README.md Adds SQL EULA guidance.
samples/​web-app-sql-database/​dotnet/​README.md Adds prerequisite and EULA guidance.
samples/​web-app-sql-database/​dotnet/​bicep/​README.md Adds SQL EULA guidance.
samples/​web-app-postgresql-flexible-server/​python/​README.md Adds lstk prerequisite.
samples/​web-app-postgresql-flexible-server/​dotnet/​README.md Adds lstk prerequisite.
samples/​web-app-mysql-flexible-server/​python/​README.md Adds lstk prerequisite.
samples/​web-app-mysql-flexible-server/​dotnet/​README.md Adds lstk prerequisite.
samples/​web-app-managed-identity/​python/​README.md Adds lstk prerequisite.
samples/​web-app-managed-identity/​dotnet/​README.md Adds lstk prerequisite.
samples/​web-app-custom-image/​python/​README.md Adds lstk prerequisite.
samples/​web-app-custom-image/​dotnet/​README.md Adds lstk prerequisite.
samples/​web-app-cosmosdb-nosql-api/​python/​README.md Adds lstk prerequisite.
samples/​web-app-cosmosdb-nosql-api/​dotnet/​README.md Adds lstk prerequisite.
samples/​web-app-cosmosdb-mongodb-api/​python/​README.md Adds lstk prerequisite.
samples/​web-app-cosmosdb-mongodb-api/​dotnet/​README.md Adds lstk prerequisite.
samples/​web-app-app-configuration/​python/​README.md Adds lstk prerequisite.
samples/​web-app-app-configuration/​dotnet/​README.md Adds lstk prerequisite.
samples/​servicebus/​java/​README.md Adds a duplicate lstk prerequisite.
samples/​function-app-storage-http/​dotnet/​README.md Adds an lstk prerequisite.
samples/​function-app-service-bus/​dotnet/​README.md Adds lstk prerequisite.
samples/​function-app-managed-identity/​python/​README.md Adds lstk prerequisite.
samples/​function-app-front-door/​python/​README.md Adds a duplicate lstk prerequisite.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread samples/function-app-front-door/python/README.md Outdated
Comment thread samples/function-app-storage-http/dotnet/README.md Outdated
Comment thread samples/servicebus/java/README.md Outdated
Comment thread samples/web-app-sql-database/dotnet/README.md Outdated
Comment thread samples/web-app-sql-database/dotnet/bicep/README.md Outdated
Comment thread samples/web-app-sql-database/python/README.md
Comment thread samples/web-app-sql-database/python/README.md Outdated
Comment thread samples/web-app-sql-database/python/bicep/README.md Outdated
Comment thread samples/web-app-sql-database/python/scripts/README.md Outdated
Comment thread samples/web-app-sql-database/python/terraform/README.md Outdated
paolosalvatori and others added 7 commits October 14, 2026 15:57
Removed duplicate lstk CLI entry from prerequisites.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated the lstk CLI entry for clarity.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Removed duplicate entry for lstk CLI in prerequisites.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README.md to use HTTPS format and clarified environment variable settings for the emulator.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README to use HTTPS and fixed formatting issues.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README to use HTTPS and fixed formatting.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
paolosalvatori and others added 5 commits October 14, 2026 16:00
Updated links in README to use proper formatting and added note about setting MSSQL_ACCEPT_EULA in the container environment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README to use proper formatting and fixed EULA note.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README to use proper formatting.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README.md to use HTTPS format.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Updated links in README to use HTTPS and fixed formatting.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@paolosalvatori
paolosalvatori merged commit 77e1037 into main Oct 14, 2026
8 checks passed

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants