Repository navigation
chore: bump rtc-ffi-bindings to 0.12.83. - #748
Conversation
🦋 Changeset detectedLatest commit: fe18cb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
🔵 Needs a closer look
Native runtime compatibility and the described libwebrtc/WARP behavior require cross-platform validation not established by this review.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Updates the RTC package’s native bindings from 0.12.73 to 0.12.83, targeting the described libwebrtc m150 upgrade with WARP enabled by default.
Changes:
- Bumps the pinned bindings dependency.
- Synchronizes lockfile versions and integrity hashes for all supported platform binaries.
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates bindings and platform-specific dependency resolutions. |
| packages/livekit-rtc/package.json | Pins RTC bindings to 0.12.83. |
Review effort: Balanced
* fix: address data streams e2e test failure * test: tolerate a clean end-of-stream when the room disconnects CI has seen a clean eos land before disconnect completes, ending the read with the chunks buffered so far. Accept that outcome again while the native cause is investigated.
|
Note that the e2e tests still seem to fail periodically with the below: This seems to be flaky starting with this FFI update, in previous FFI releases this was fine. My current theory is that livekit/rust-sdks#1395 is causing ffi objects to be double disposed. I've opened a PR here to try to fix this: livekit/rust-sdks#1539 |
1egoman
left a comment
There was a problem hiding this comment.
I gave this a shot with agents-js locally and it looks good to me!
Two nitpicks:
- Consider bumping to 0.13.1 as it has been released within the past few hours and has a small security related fix.
- Please add a changeset (run
npx @changesets/cliand follow the prompts) before merging.
ddbb428 to
fe18cb6
Compare
To confirm ffi-bindings upgrade to 0.12.76+ (libwebrtc m150, with WARP enabled by default).