Skip to content

chore: bump rtc-ffi-bindings to 0.12.83. - #748

Merged
cloudwebrtc merged 6 commits into
mainfrom
duan/bump-rtc-ffi-bindings
Oct 21, 2026
Merged

cloudwebrtc merged 6 commits into
mainfrom
duan/bump-rtc-ffi-bindings

Conversation

@cloudwebrtc

@cloudwebrtc cloudwebrtc commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

To confirm ffi-bindings upgrade to 0.12.76+ (libwebrtc m150, with WARP enabled by default).

@changeset-bot

changeset-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fe18cb6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@livekit/rtc-node Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

devin-ai-integration[bot]

This comment was marked as resolved.

@cloudwebrtc
cloudwebrtc requested review from 1egoman and a balanced review from Copilot October 19, 2026 09:56

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Native runtime compatibility and the described libwebrtc/WARP behavior require cross-platform validation not established by this review.

No open issues 🎉

1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

Updates the RTC package’s native bindings from 0.12.73 to 0.12.83, targeting the described libwebrtc m150 upgrade with WARP enabled by default.

Changes:

  • Bumps the pinned bindings dependency.
  • Synchronizes lockfile versions and integrity hashes for all supported platform binaries.
File Description
pnpm-lock.yaml Updates bindings and platform-specific dependency resolutions.
packages/​livekit-rtc/​package.json Pins RTC bindings to 0.12.83.

Review effort: Balanced

* fix: address data streams e2e test failure

* test: tolerate a clean end-of-stream when the room disconnects

CI has seen a clean eos land before disconnect completes, ending the
read with the chunks buffered so far. Accept that outcome again while
the native cause is investigated.
@1egoman

1egoman commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Note that the e2e tests still seem to fail periodically with the below:

⎯⎯⎯⎯⎯ Uncaught Exception ⎯⎯⎯⎯⎯
Error: trying to drop an invalid handle
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
Serialized Error: { code: 'GenericFailure' }
This error originated in "src/tests/e2e_data_streams.test.ts" test file. It doesn't mean the error was thrown inside the file itself, but while it was running.
⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯

This seems to be flaky starting with this FFI update, in previous FFI releases this was fine. My current theory is that livekit/rust-sdks#1395 is causing ffi objects to be double disposed. I've opened a PR here to try to fix this: livekit/rust-sdks#1539

@1egoman 1egoman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a shot with agents-js locally and it looks good to me!

Two nitpicks:

  • Consider bumping to 0.13.1 as it has been released within the past few hours and has a small security related fix.
  • Please add a changeset (run npx @changesets/cli and follow the prompts) before merging.

@cloudwebrtc
cloudwebrtc force-pushed the duan/bump-rtc-ffi-bindings branch from ddbb428 to fe18cb6 Compare October 21, 2026 00:19
@cloudwebrtc
cloudwebrtc merged commit a7fcb4a into main Oct 21, 2026
10 checks passed
@cloudwebrtc
cloudwebrtc deleted the duan/bump-rtc-ffi-bindings branch October 21, 2026 01:39
@github-actions github-actions Bot mentioned this pull request Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants