Repository navigation
Smoke test: do not wait for a verification the server does not start - #194
Merged
Merged
Conversation
…st verified the fixture The server only verifies on the first file opened, so after the state error test the smoke test waited for diagnostics that never came whenever that test's notifications had all arrived before it ended. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the integration failure on main after #191 (stable) and the earlier ones on #189 (minimum) and #193 (both). Each time it was the same test timing out:
smoke.test.ts› "activates, becomes ready, and verifies its isolated fixture".Cause
The server only verifies when the first file of the workspace is opened (
LJDiagnosticsService.didOpen). In thefailingfixture,state-errors.test.tsruns first and opens and verifies the fixture. The smoke test then opensFailingRefinement.javaand waits for a verification that the server never starts. It passed only when a late notification from the earlier test happened to arrive while it waited, which is why it failed on some runs and VS Code versions and not others.Change
The smoke test waits for the verification on open only when the fixture has not been verified yet. It still runs the manual
liquidjava.verifyand checks its result as before.Tests
xvfb-run -a npm test(VS Code 1.82, the minimum) passes twice in a row, 9 + 1 tests;test:typecheckandlintpass.🤖 Generated with Claude Code