Repository navigation
Bump liquidjava-verifier to 0.0.37 and liquidjava-fsm to 0.2.3 - #179
Merged
Merged
Conversation
The error constructors take the aliases of a refinement error and how a state error shows its states, and a variable's name is now written as in code, so the converter test builds them that way. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CatarinaGamboa
added a commit
that referenced
this pull request
Nov 10, 2026
…'s spec (#174) Closes #173. Uses liquidjava-fsm 0.2.3 (which includes [liquidjava-fsm#16](liquid-java/liquidjava-fsm#16)) and verifier 0.0.37, both on main since #179. Rebased onto main on 2026-11-10: the `server/pom.xml` bump is gone; server tests pass (39 with #178 merged in too). ## Why A state error can be on a method declared in a subclass's spec (`Frame.setUndecorated`) while the state set is declared in a superclass's spec (`Window`). In that case the State Machine view could not explain the error: - With verifier 0.0.36 (no state context), it showed `Window`'s diagram without `setUndecorated` and marked no states (the issue's screenshot). - With verifier main (liquid-java/liquidjava#464), the context names `java.awt.Frame`. The parser then found `Frame`'s spec, which has no `@StateSet`, so the error had no diagram at all. ## What - **liquidjava-fsm#16.** The parser merges the specs of a class's supertypes, following the rule from liquidjava#464: state sets of the class and then of its supertypes, nearest first; for each method, the class's own refinement, otherwise that of the nearest type that declares it. The details are in that PR. - **`StateRefinementErrorDTO`.** It parses the diagrams for the context's `receiverClass`. It reads the declaration's file plus the files of the state sets and state refinements the verifier registered (`ContextHistory`), so specs split across files are found, including a supertype spec with methods but no state set. Without a context it behaves as before (first class of the declaration's file). - **Known limit.** A project class that extends an unannotated project class in a file the verifier registered nothing for stops the walk there, so that class's diagram leaves out the states further up. The parser only sees the spec files. No verifier change is needed. liquidjava#464 already sends the context with the receiver's states for this case. The view needs a verifier release with #464 (after 0.0.36). With 0.0.36 nothing changes for this case: that verifier sends no context, so the view still shows the first class of the declaration's file (`Window` in the issue's file). ## Screenshots Both columns use verifier main @ 9e4b5e64. | | Before (main) | After | |---|---|---| | Issue reproducer (`host.pack(); host.setUndecorated(true);`) | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/174/before-issue.png" width="380"> | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/174/after-issue.png" width="380"> | | Study exercise A1_09 (LITIENGINE `GameWindow`) | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/174/before-a1-09.png" width="380"> | <img src="https://raw.githubusercontent.com/liquid-java/vscode-liquidjava/pr-screenshots/174/after-a1-09.png" width="380"> | In A1_09 the actual state shows as "unknown" because the verifier finds both `displayable` and `notDisplayable` possible (it depends on the path). `notDisplayable` is marked as the expected state, and `setUndecorated` is the failing call. I did not take a split-files screenshot. With `FrameRefinements.java` read before `WindowRefinements.java`, the verifier stops with liquid-java/liquidjava#461 before it reaches the state error. `StateRefinementErrorDTOTest` covers that layout. ## Tests - server `mvn test`: 39 passed, 0 failures (liquidjava-fsm 0.2.3 built locally from #16, verifier 0.0.36). New `StateRefinementErrorDTOTest`: - Specs in two files: the diagram is `java.awt.Frame`, with `setUndecorated`, `dispose` and `pack` on `Window`'s states; `displayable` is marked invalid and `notDisplayable` accepted. - Without a context: the first class of the declaration's file, as before. - A `JFrame` spec over a method-only `Frame` spec and `Window`'s state set: all their methods are drawn. - The verifier run on that fixture: the files of all three specs are selected. - client `npm run test:unit`: 123 passed. `npm run test:typecheck`: clean. `npm test` (VS Code): 9 + 1 passing. ## Overlap with #172 None. #172 changes only the client webview. This PR changes only the server and its fsm dependency. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
CatarinaGamboa
added a commit
that referenced
this pull request
Nov 10, 2026
Build: vscode-liquidjava main 7292a64 (#179) + #178 (04246ac) + #174 (974043b), merged locally; verifier 0.0.37, fsm 0.2.3 from Central. Files named *-ways-to-fix-pr172.png add #172 (6d41838) on top. Exercises: building-examples-liquidjava proposal-d-state-values, api 0.0.8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up verifier 0.0.37 (named state sets, states written as values of their sets,
x@linedisplay names, hints and found trimming since 0.0.36) and fsm 0.2.3 (reads named sets and the value form; built on verifier 0.0.37).Server changes are only in
DiagnosticConverterTest:RefinementErrortakes the refinement's aliases andStateRefinementErrorhow it shows its states (UnaryOperator<Expression>); the tests passList.of()andUnaryOperator.identity().VariableFormatter.formatnow writes#value_12asvalue(no superscript counter); variables that would read alike are told apart by the verifier asx@line. The translation-table test expectsvalue.The client still knows superscript counters (
highlighting.ts,vc-changes.ts, a fixture instate-errors.spec.ts); rendering thex@linenames is #175.Server: 35 tests pass locally. #178 (named set titles) goes on top of this.
🤖 Generated with Claude Code