Repository navigation
Save notes when the session manager stops the application - #177
Open
lucastanure wants to merge 1 commit into
Open
lucastanure wants to merge 1 commit into
lucastanure wants to merge 1 commit into
Conversation
Text typed into a note reaches the disk only after two chained timers: one second after the last keystroke, then three more seconds before the file is written. At logout or shutdown the session manager stops the application with SIGTERM. The process has no handler for it and dies at once, so pending timers never run and the last seconds of typing are lost. A short note written just before shutting down comes back empty after the next login. Moving or resizing a note inside that one-second window also cleared the pending "text changed" flag, so even a save that did happen could write the old text. Signed-off-by: Lucas Tanure <tanure@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text typed into a note reaches the disk only after two chained timers: one second after the last keystroke, then three more seconds before the file is written. At logout or shutdown the session manager stops the application with SIGTERM. The process has no handler for it and dies at once, so pending timers never run and the last seconds of typing are lost. A short note written just before shutting down comes back empty after the next login.
Moving or resizing a note inside that one-second window also cleared the pending "text changed" flag, so even a save that did happen could write the old text.