Repository navigation
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideThe PR updates OSD integration for Wayland by migrating brightness to Treeland output-manager v2 and disabling unsupported display-mode actions, adds Bluetooth OSD resources, initializes the panel timer earlier, expands AT-SPI expectations, and introduces standalone GoogleTest/CTest coverage for OSD panels and applets. Sequence diagram for Wayland OSD display-mode handlingsequenceDiagram
participant OSD as DisPlayModeApplet
participant Platform as DGuiApplicationHelper
participant Base as DApplet
OSD->>Platform: testAttribute(IsWaylandPlatform)
Platform-->>OSD: m_isWayland
OSD->>Base: load()
OSD->>OSD: sync()
alt Wayland platform
OSD-->>OSD: setState(2)
OSD-->>OSD: next() returns
OSD-->>OSD: doAction() returns
else Non-Wayland platform
OSD->>OSD: fetchPlanItems()
OSD->>OSD: fetchCurrentPlanItem()
end
Sequence diagram for brightness OSD Wayland protocol v2sequenceDiagram
participant Brightness as TreelandBrightness
participant Manager as treeland_output_manager_v2
participant Output as wl_output
participant Control as TreelandPictureControl
participant OSD as Brightness OSD
Brightness->>Manager: get_picture_control(output)
Manager-->>Brightness: treeland_output_picture_control_v2
Brightness->>Control: construct control
Control-->>OSD: treeland_output_picture_control_v2_brightness(brightness)
Control->>OSD: brightnessChanged(brightness)
Flow diagram for OSD test coverage and resourcesflowchart LR
Sources[OSD applets and panel] --> Tests[GoogleTest and CTest targets]
Sources --> Resources[Bluetooth OSD types and icons]
Tests --> SPI[AT-SPI expected names]
Sources --> Wayland[Wayland-specific behavior]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
TAG Bot New tag: 2.0.58 |
|
TAG Bot New tag: 2.0.59 |
Summary
This PR implements OSD Wayland adaptation, Bluetooth type additions, unit tests, and AT-SPI test expectations for dde-shell.
Changes
treelandbrightness.cpp/.h,CMakeLists.txtdisplaymodeapplet.h/.cppmain.qml, newosd_bluetooth_on.dci/osd_bluetooth_off.dcim_osdTimerinitialization moved to constructor —osdpanel.cpposdpanel_test.cpp,audioapplet_test.cpp,brightnessapplet_test.cpp,displaymodeapplet_test.cpp,CMakeLists.txtupdatesexpected_names.yamlRelated Issue
DDE-445
Summary by Sourcery
Adapt OSD functionality for Wayland, add Bluetooth notifications, and expand automated coverage for OSD components.
New Features:
Bug Fixes:
Enhancements:
Build:
Tests: