Repository navigation
feat: migrate showdesktop and multitaskview to compositor-action prot… - #1760
Merged
Merged
Conversation
Reviewer's GuideThe PR upgrades Treeland protocol usage to 0.7.0, replaces legacy DDE shell/show-desktop/lockscreen integrations with compositor-action clients that trigger named actions, removes obsolete protocol wrappers, and hardens Wayland extension destruction against uninitialized objects. Sequence diagram for compositor actions from dock and shutdown appletssequenceDiagram
participant User
participant ShowDesktop
participant MultiTaskView
participant TreeLandLockScreen
participant Compositor as TreelandCompositor
User->>ShowDesktop: toggleShowDesktop()
ShowDesktop->>Compositor: trigger(action_show_desktop)
User->>MultiTaskView: openWorkspace()
MultiTaskView->>Compositor: trigger(action_toggle_multitask_view)
User->>TreeLandLockScreen: lock()
TreeLandLockScreen->>Compositor: trigger(action_lockscreen)
User->>TreeLandLockScreen: shutdown()
TreeLandLockScreen->>Compositor: trigger(action_shutdown_menu)
User->>TreeLandLockScreen: switchUser()
TreeLandLockScreen->>Compositor: trigger(action_show_user_switch)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
18202781743
approved these changes
Oct 13, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wineee The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…ocol 1. Rewrite showdesktop wrapper to use treeland-compositor-action-unstable-v1 2. Rewrite multitaskview wrapper to use treeland-compositor-action-unstable-v1 3. Remove old state tracking logic from showdesktop wrapper 4. Remove two-step worker pattern from multitaskview wrapper 5. Update CMakeLists.txt to use new protocol XML and treeland-protocols 0.7.0 6. Update debian/control build dependency to treeland-protocols (>= 0.7.0) Log: Migrated show desktop and multitask view to compositor action protocol Influence: 1. Test show desktop toggle on Wayland session 2. Test multitask view toggle on Wayland session 3. Verify X11 fallback paths remain unchanged 4. Verify build with treeland-protocols 0.7.0 installed feat: 迁移显示桌面和多任务视图至 compositor-action 协议 1. 重写 showdesktop 包装类，使用 treeland-compositor-action-unstable-v1 协议 2. 重写 multitaskview 包装类，使用 treeland-compositor-action-unstable-v1 协议 3. 移除 showdesktop 包装类中旧的状态跟踪逻辑 4. 移除 multitaskview 包装类中的两步式 worker 模式 5. 更新 CMakeLists.txt 使用新协议 XML 和 treeland-protocols 0.7.0 6. 更新 debian/control 构建依赖至 treeland-protocols (>= 0.7.0) Log: 迁移显示桌面和多任务视图功能至 compositor action 协议 Influence: 1. 在 Wayland 会话下测试显示桌面切换功能 2. 在 Wayland 会话下测试多任务视图切换功能 3. 验证 X11 回退路径保持不变 4. 验证安装 treeland-protocols 0.7.0 后可正常编译
1. Add null-safe destroy() guards to avoid crash on uninitialized proxy 2. Replace isActive() with isInitialized() to prevent proxy leak on global removal 3. Add missing destructors for WallpaperColorManager and keyboard notify objects Log: No user-facing changes Influence: 1. Run dock panel on a non-treeland Wayland compositor and quit normally 2. Toggle SmartHide mode repeatedly and verify region watch is released 3. Switch CapsLock/NumLock and shutdown/lockscreen on Wayland to confirm no crash fix: 使用 isInitialized 保护 Wayland 协议析构销毁 1. 为 destroy() 增加空指针保护，避免未初始化代理崩溃 2. 将 isActive() 改为 isInitialized()，防止 global 移除后代理泄漏 3. 补齐 WallpaperColorManager 与键盘通知对象的析构销毁 Log: 无用户可见变化 Influence: 1. 在非 treeland 的 Wayland 合成器上运行 dock 面板并正常退出 2. 反复切换智能隐藏模式，确认区域监听已释放 3. 在 Wayland 下切换大小写/数字锁定与关机/锁屏，确认无崩溃
Contributor
|
/forcemerge |
|
This pr force merged! (status: blocked) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Migrate desktop actions to the shared compositor-action protocol and harden Wayland client-extension cleanup.
Bug Fixes:
Enhancements:
Build:
Chores: