Skip to content

LCORE-4710: Fixed ruff issues - #3137

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:fix-crossencoder-ruff-imports
Nov 3, 2026
Merged

tisnik merged 1 commit into
lightspeed-core:mainfrom
asimurka:fix-crossencoder-ruff-imports

Conversation

@asimurka

@asimurka asimurka commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library [pyproject.toml + uv.lock]
  • Bump-up dependent library [requirements.*.txt for Konflux]
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: (e.g., Claude, CodeRabbit, Ollama, etc., N/A if not used)
  • Generated by: (e.g., tool name and version; N/A if not used)

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1aee84a and e0f19f5.

Files selected for processing: 9
  • scripts/generate_openapi_schema.py
  • scripts/latest_tag.py
  • scripts/vulnerability_report.py
  • src/providers/inference/azure/provider.py
  • src/providers/inference/bedrock/provider.py
  • src/providers/inference/openai/provider.py
  • src/providers/inference/vertexai/provider.py
  • src/providers/inference/vllm/provider.py
  • src/providers/inference/watsonx/provider.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fullsend-ai-review

fullsend-ai-review Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:37 PM UTC · Completed 1:52 PM UTC

Commit: e0f19f5 · View workflow run →

Runtime: pi · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.64

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Nov 3, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: moderate (2/5)

Details

Small mechanical ruff-linting fix (18 lines across 9 files). Score elevated above 1 by PROTECTED_PATH_COUNT=3 (score 5) and TEST_FILE_RATIO=0.00 (score 5), but actual changes are trivial unused-import removals and docstring whitespace with near-zero behavioral risk.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] scripts/ — PR modifies files under protected path scripts/: scripts/generate_openapi_schema.py, scripts/latest_tag.py, scripts/vulnerability_report.py. Human approval is always required for protected-path changes, regardless of context. The changes are mechanical ruff linting fixes (adding blank lines before closing docstring quotes).

Labels: Mechanical ruff linting fix across Python provider and script files.

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment python Pull requests that update python code Review effort 1/5 labels Nov 3, 2026

@tisnik tisnik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik
tisnik merged commit 668a10a into lightspeed-core:main Nov 3, 2026
96 of 102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update python code requires-manual-review Review requires human judgment Review effort 1/5 risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants