Repository navigation
LCORE-4751: remove ogx_version from GET /v1/info - #3133
Open
max-svistunov wants to merge 1 commit into
Open
max-svistunov wants to merge 1 commit into
max-svistunov wants to merge 1 commit into
Conversation
Keep /v1/info as an LCORE identity endpoint that returns name and service_version only. Drop the OGX inspect.version() call, the ogx_version field of InfoResponse and the now unreachable OGX error handling, so the endpoint answers 200 while OGX is unreachable instead of 503. The 503 stays documented for the Kubernetes authentication backend. The startup version check in src/utils/ogx_version.py is unchanged. Update unit, integration and e2e tests, including the ogx_disrupted scenario, regenerate the OpenAPI and model docs, and add the change to the v0.8.0 migration notes.
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 31 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LCORE-4751:
GET /v1/infobecomes an LCORE identity endpoint. It returnsnameandservice_versiononly and no longer calls OGXinspect.version(). Theogx_versionfield is removed fromInfoResponsewith no replacement, as the ticket and the catalog and health endpoints design ask.Visible API changes, both recorded in
docs/migrations/v0.8.0.md:ogx_versionis gone from the response.Unable to connect to OGX. UseGET /readinessto detect whether OGX is available.ogx_versionwas never marked deprecated, so this removes it without the usual deprecation phase of one minor release. The removal follows the design doc, andllama_stack_versionwas dropped the same way in 0.7. If a deprecation phase is preferred, the field can stay in 0.8 marked deprecated, with the removal moved to the next minor release.The endpoint keeps 503 in its documented responses because Kubernetes authentication can still return it; only the OGX example is dropped.
src/app/main.pyandsrc/utils/ogx_version.pyare unchanged: the startup version check still needs them.OpenAPI and the model docs are updated. The e2e scenario in
ogx_disrupted.featurenow expects 200 instead of 503, and the unusedogx versionstep is removed.Type of change
pyproject.toml+uv.lock]requirements.*.txtfor Konflux]Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
inforouter on a FastAPI app with noop authentication, pointogx.urlat a closed port, and callGET /v1/info. Expected: 200 with onlynameandservice_version. Actual:200 {"name":"http-check","service_version":"0.8.0rc1"}..venv/bin/python -m pytest tests/unit/app/endpoints/test_info.py tests/unit/models/responses/test_successful_responses.py::TestInfoResponse tests/unit/utils/dumpers/test_models_dumper.py tests/integration/endpoints/test_info_integration.py. They all pass.tests/integration/container_lifecycle: 372 passed.tests/e2e/features/info.featureandtests/e2e/features/ogx_disrupted.feature. These were not run against a live stack for this PR; abehave --dry-runconfirms that all their steps resolve, so the CI e2e jobs are their first real run.