Repository navigation
Use manual downloads for test binaries - #1173
Merged
Merged
Conversation
|
👋 Thanks for assigning @joostjager as a reviewer! |
Fresh builds fail because automatic test binary downloads require yanked zip releases. The no_download configuration still leaves these requirements in Cargo's dependency graph. Use the existing verified download script for local test binaries, including the VSS jobs, which share the Rust workflow's binary caches. Document the required environment so fresh builds and local tests work with the current harness releases. Upstream fix: https://git.rust-bitcoin.org/rust-bitcoin/corepc/pulls/720 Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-10-fix-yanked-zip
branch
from
October 16, 2026 10:23
6a176d6 to
a0b9593
Compare
joostjager
approved these changes
Oct 16, 2026
| repository: lightningdevkit/vss-server | ||
| path: vss-server | ||
|
|
||
| - name: Enable caching for bitcoind |
Contributor
There was a problem hiding this comment.
Code duplicated below, but not sure if there's a reasonable extraction. Needs updating in two places when core is updated now.
Collaborator
Author
There was a problem hiding this comment.
Yeah, it intentionally copying the approach in rust.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh builds fail because automatic test binary downloads require yanked
zipreleases. Theno_downloadconfiguration still leaves these requirements in Cargo's dependency graph.Use the existing verified download script for local test binaries, including the VSS jobs. Document the required environment so fresh builds and local tests work with the current harness releases.
Upstream fix: https://git.rust-bitcoin.org/rust-bitcoin/corepc/pulls/720