Repository navigation
Move ChainListener from chain::bitcoind to chain - #1162
Merged
tnull merged 1 commit intoOct 14, 2026
Merged
Conversation
`ChainListener` fans out LDK's `Listen` callbacks to the on-chain wallet, `ChannelManager`, `ChainMonitor` and `OutputSweeper`. It is not specific to the bitcoind backend, so any other block-driven chain source needs the same type. Move it, unchanged, next to `ChainSource` in `chain/mod.rs` so that other chain sources can reuse it without reaching into the bitcoind module. It stays gated on `chain-bitcoind`, its only user for now. No functional change. Co-authored-by: febyeji <yeji.han@sf.snu.ac.kr>
|
I've assigned @tnull as a reviewer! |
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChainListenerfans out LDK'sListencallbacks to the on-chain wallet,ChannelManager,ChainMonitorandOutputSweeper. It is not specific to the bitcoind backend, so any other block-driven chain source needs the same type.Move it, unchanged, next to
ChainSourceinchain/mod.rsso that other chain sources can reuse it without reaching into the bitcoind module. It stays gated onchain-bitcoind, its only user for now (compact block filter chain source will be another user).No functional change.