Skip to content

Fix checked stop on localized Windows Task Scheduler states - #9041

Draft
stanthewizzard wants to merge 2 commits into
lidge-jun:devfrom
stanthewizzard:fix/windows-scheduler-state-com
Draft

stanthewizzard wants to merge 2 commits into
lidge-jun:devfrom
stanthewizzard:fix/windows-scheduler-state-com

Conversation

@stanthewizzard

@stanthewizzard stanthewizzard commented Nov 21, 2026 •

Copy link
Copy Markdown

Summary

On French Windows, schtasks reports Prêt for a ready task. The existing PowerShell fallback took about 1.5 seconds on the affected machine, beyond the one-second state budget, and service installation rolled back. Read the numeric TASK_STATE through Schedule.Service when the CSV fast path cannot classify the result. Queued and running remain active. Failed, timed-out and unknown reads remain inconclusive.

Verification

  • Ran bun test tests/windows/windows-checked-stop-live.test.ts on Windows. All 42 tests passed.
  • Measured the COM read at 299–337 ms including PowerShell startup on the affected French host.
  • With the patch applied to 2.100.8, the scheduler installer completed instead of rolling back. End-to-end tray behavior is still being checked.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • Required local validation passed; commands, results, and any full-suite exception are documented.

  • I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Nov 21, 2026
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
  • ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

Hygiene

✅ Deterministic PR hygiene checks passed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant