Repository navigation
ci: raise the Windows shard timeout to 40 minutes - #9033
Conversation
Windows shards keep reaching the 30-minute wall with no failing test: on dev 067f623 shard 14/14 was cancelled at batch 39/46 in both attempts of run 44898495822, and runs 44809394399 and 44878221019 lost other shards the same way. A cancelled shard is neither a pass nor a fail, so it blocks release evidence without showing a fault. Raise only platform-windows timeout-minutes to 40, as #8944 did for the Linux shards, and pin the new ci.yml blob with an appended release-evidence policy entry (the previous ci entry with only the ci.yml hash replaced).
|
Maintainer security review (coordinator for @lidge-jun): workflow change limited to platform-windows timeout-minutes 30 -> 40 plus the matching release-evidence policy pin; no trigger, permission, runner, action ref or secret change. maintainer-sponsored applied at c405798. |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Shorten the new platform-windows timeout rationale to one line and re-pin the ci.yml blob in the release-evidence policy entry.
|
Re-review at 39b7ef8: the follow-up only shortens the ci.yml comment to stay under the 2,000-line module cap (1,999 lines) and re-pins the ci.yml blob (cdfc4ea31e) in the appended policy entry. Same timeout change; maintainer-sponsored re-applied for this head. |
|
Maintainer integration into dev (MAINTAINERS.md dev-only exception), recorded by the coordinator for @lidge-jun: exact head 39b7ef8, all 31 checks green, no open review threads; workflow change reviewed above (maintainer-sponsored). |
Summary
Windows test shards keep hitting the 30-minute job wall with no failing test, which blocks release evidence (a cancelled shard is neither a pass nor a fail):
067f6231f6, run 44898495822: shard 14/14 cancelled at batch 39/46 in both attempts, 0(fail)lines.This raises only
platform-windowstimeout-minutesfrom 30 to 40, the same remedy #8944 applied to the Linux shards, and pins the newci.ymlblob (cdfc4ea31e) with an appended release-evidence policy entry that copies the previouscientry and replaces only theci.ymlhash. No job, trigger, permission, runner or shard-count change. Refreshing the Windows duration weights and revisiting the shard count is left as follow-up.Verification
tests/ci-workflows/ci-workflows.test.tsupdated to expect 40 forplatform-windows; PR CI runs it.cientry except.github/workflows/ci.yml=git hash-objectof the new file; JSON re-serialized with the file's existing 2-space format.ci.yml lane=alldispatch ondevafter merge.Checklist
Summary by CodeRabbit