Skip to content

ci: raise the Windows shard timeout to 40 minutes - #9033

Merged
lidge-jun merged 2 commits into
devfrom
codex/ci-windows-shard-timeout-40
Nov 21, 2026
Merged

lidge-jun merged 2 commits into
devfrom
codex/ci-windows-shard-timeout-40

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 21, 2026 •

Copy link
Copy Markdown
Owner

Summary

Windows test shards keep hitting the 30-minute job wall with no failing test, which blocks release evidence (a cancelled shard is neither a pass nor a fail):

  • dev 067f6231f6, run 44898495822: shard 14/14 cancelled at batch 39/46 in both attempts, 0 (fail) lines.
  • runs 44809394399 and 44878221019: other Windows shards cancelled at 30 minutes, 0 failing tests.

This raises only platform-windows timeout-minutes from 30 to 40, the same remedy #8944 applied to the Linux shards, and pins the new ci.yml blob (cdfc4ea31e) with an appended release-evidence policy entry that copies the previous ci entry and replaces only the ci.yml hash. No job, trigger, permission, runner or shard-count change. Refreshing the Windows duration weights and revisiting the shard count is left as follow-up.

Verification

  • tests/ci-workflows/ci-workflows.test.ts updated to expect 40 for platform-windows; PR CI runs it.
  • Policy entry: identical to the last ci entry except .github/workflows/ci.yml = git hash-object of the new file; JSON re-serialized with the file's existing 2-space format.
  • The deciding evidence is the next ci.yml lane=all dispatch on dev after merge.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed. (Rationale recorded in the ci.yml comment.)
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. (Workflow change limited to one timeout; no permissions, triggers or third-party action refs change.)

Summary by CodeRabbit

  • Maintenance
    • Increased the Windows CI job timeout from 30 to 40 minutes.

Windows shards keep reaching the 30-minute wall with no failing test: on dev
067f623 shard 14/14 was cancelled at batch 39/46 in both attempts of run
44898495822, and runs 44809394399 and 44878221019 lost other shards the same
way. A cancelled shard is neither a pass nor a fail, so it blocks release
evidence without showing a fault.

Raise only platform-windows timeout-minutes to 40, as #8944 did for the Linux
shards, and pin the new ci.yml blob with an appended release-evidence policy
entry (the previous ci entry with only the ci.yml hash replaced).
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 21, 2026 12:23
@lidge-jun lidge-jun added the maintainer-sponsored Maintainer sponsors this change to an auth, workflow, release, or dependency surface label Nov 21, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer security review (coordinator for @lidge-jun): workflow change limited to platform-windows timeout-minutes 30 -> 40 plus the matching release-evidence policy pin; no trigger, permission, runner, action ref or secret change. maintainer-sponsored applied at c405798.

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T12:24:55.743583Z c405798 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions github-actions Bot added the chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). label Nov 21, 2026
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The platform-windows CI job timeout increased from 30 to 40 minutes. Its test expectation and a CI release evidence policy record were also updated.

Changes: Windows CI timeout

Layer / File(s) Summary
Timeout and evidence update
.github/workflows/ci.yml, tests/ci-workflows/ci-workflows.test.ts, .github/scripts/release-evidence-policy.json
The platform-windows timeout increased to 40 minutes. The workflow comment records that all 14 shards reached the previous limit at batch 39/46 in run 44898495822. The test now expects 40 minutes, and the policy includes a record with 14 Windows shards and file hashes.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

  • lidge-jun/opencodex#8944: Raises CI timeouts, updates workflow test expectations, and adds a CI workflow hash to the release evidence policy.
Merge Risk: Minimal · up to 39b7e

This change gives Windows CI shards 10 more minutes so they stop being cancelled at the time limit. It also updates the matching test and the release-evidence policy pin. No trigger, permission, runner, or shard-count change is involved. It is low risk to merge, and the next full CI run on dev will show whether 40 minutes is enough.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "ci: raise the Windows shard timeout to 40 minutes" matches the main change. The PR raises the timeout-minutes of the platform-windows job in .github/workflows/ci.yml from 30 to 40, and the …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci: raise the Windows shard timeout to 40 minutes" matches the main change. The PR raises the timeout-minutes of the platform-windows job in .github/workflows/ci.yml from 30 to 40, and the test in tests/ci-workflows/ci-workflows.test.ts is updated to expect 40. The title is short, specific, and uses a conventional commit prefix. The release-evidence policy entry is a supporting change that the title does not mention, which is acceptable because the title does not need to cover every detail.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between c405798 and 39b7ef8.

Files selected for processing: 2

  • .github/scripts/release-evidence-policy.json
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Shorten the new platform-windows timeout rationale to one line and re-pin the ci.yml blob in the release-evidence policy entry.
@lidge-jun lidge-jun added maintainer-sponsored Maintainer sponsors this change to an auth, workflow, release, or dependency surface and removed maintainer-sponsored Maintainer sponsors this change to an auth, workflow, release, or dependency surface labels Nov 21, 2026
@lidge-jun

Copy link
Copy Markdown
Owner Author

Re-review at 39b7ef8: the follow-up only shortens the ci.yml comment to stay under the 2,000-line module cap (1,999 lines) and re-pins the ci.yml blob (cdfc4ea31e) in the appended policy entry. Same timeout change; maintainer-sponsored re-applied for this head.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev (MAINTAINERS.md dev-only exception), recorded by the coordinator for @lidge-jun: exact head 39b7ef8, all 31 checks green, no open review threads; workflow change reviewed above (maintainer-sponsored).

@lidge-jun
lidge-jun merged commit 9e0e298 into dev Nov 21, 2026
39 of 47 checks passed
@lidge-jun
lidge-jun deleted the codex/ci-windows-shard-timeout-40 branch November 21, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). maintainer-sponsored Maintainer sponsors this change to an auth, workflow, release, or dependency surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant