Repository navigation
Conversation
Use same-account query handles for eligible wrapper snapshots and captured Scheduler engines on Windows x64. Keep ambiguous identities, expired deadlines and changed registrations refused, and report Windows stop evidence separately from a registration query failure.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
✅ Deterministic PR hygiene checks passed. |
|
Windows Sandbox acceptance on The guest started with empty application homes, no registered OpenCodex task and no listener on port 10100. I timed a read-only control inside the same guest, from spawning trusted Windows PowerShell until child exit. Empty startup/exit took 1.94 s. With the task absent, the initial registration lookup from the native helper took 2.60 s and 2.32 s; the equivalent legacy helper took 2.76 s and 2.42 s. Each lookup exceeded the existing 2 s task-end budget, before any per-engine owner query was needed. These controls do not establish which COM or authorization step the original install reached. This leaves two separate results: the actual-handle fallback accepted a same-account wrapper with a missing WMI owner in the physical Windows check, while the full install-to-stop acceptance remains open on this guest. The original reporter's 1 s WMI-owner symptom and this guest's task-end timeout should be tracked separately. |
Resolve against lidge-jun#8931 and lidge-jun#8974: keep dev's framed baseline snapshot, partial output, stop-before cutoff and mutation evidence, and apply this branch's native engine-identity proof and missing-owner fallback on top. The engine-proof verdict still has to match the helper verdict, and the fixture helper gains the dev clock and approval stubs plus both scenario sets.
|
Integration status from the current maintainer batch:
This stays in draft: the PR's own checklist asks for a maintainer security review of the process-identity binding, and native Windows validation is still outstanding. I've handed it to the maintainers for that review. |
|
Thanks for resolving the merge. I tested the published head One non-mutating timing edge remains in the shared Scheduler helper. When an empty instance collection was returned and the final COM The earlier Sandbox install result applied to |
Summary
service_state_unknowncontract.Refs #9026. The reported WMI latency is specific to the reporter's host. This draft is ready for ownership-boundary review and independent Windows testing.
Verification
bun test --isolateacross seven files covering process evidence, wrapper binding, checked stop, its command adapter and callers, the Windows CLI stop, and graceful process control: 198 passed, 0 failed (946 assertions).bun run typecheck(2,688 files),bun run structure:check,bun run privacy:scan,git diff --check, and the documentation build (820 pages, 126,243 internal links) passed. Local coverage was focused to keep the full shared Windows run bounded. Upstream CI is checked separately for the submitted head.Checklist