Repository navigation
feat(gui): drop Start at Login from the desktop Getting started and let Home hide it - #9007
Conversation
…e hide Getting started Inside the OpenCodex desktop app, the app's install and first run already turn Start at Login on, so Home and the Set up hub no longer list that step there (Home reads "X of 2"). The browser dashboard keeps its step unchanged. Home's Getting started card gains a Hide control, remembered per browser profile in localStorage; Recent errors and the other Home cards stay. Hiding offers Undo for that visit, and the Set up hub brings the card back with Show on Home. Copy for all 11 locales lives in getting-started-copy.ts.
Writable but unreadable storage made Hide revert on the next read; the store now answers with the last choice made in this window. Only localStorage events reconcile the choice, so a sessionStorage clear elsewhere cannot drop an unsaved one. The Set up hub test asserts where focus lands after Show on Home.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer integration into
|
Summary
Inside the OpenCodex desktop app, Home → Getting started read "2 of 3 done" and kept asking for Turn on Start at Login, even though the app's install and first launch already turn Start at Login on (
desktop/src-tauri/src/first_run.rs). The card also could not be put away once someone was done with it.isDesktopShell()). Home now reads "X of 2" and the Checklist "X of 3". The browser dashboard keeps its step exactly as before, including the Desktop wording it shows when the app runs the proxy.localStorage(ocx-home-getting-started-hidden), so it is remembered per browser profile, and the app's window keeps its own. Only that card goes away; the stat tiles, the profile card and Recent errors stay, and Recent errors takes the full row. Right after hiding, a one-line note says where to bring it back, with Undo; keyboard focus moves to Undo, and back to Hide after Undo.sessionStorageclear elsewhere cannot undo an unsaved choice.gui/src/i18n/getting-started-copy.tsand is spread throughshellV2Copy(), so no locale catalog changed. The English desktop guide describes the in-app checklist and how to hide and restore it; translated guides never described the checklist, so nothing there contradicts it.Start at Login detection (
src/service/desktop-startup.ts) and the Startup page are unchanged.Prior art for the hide-and-restore pattern: dismissible checklists say "Hide" rather than "Close" and keep a permanent way back (saasui.design); onboarding should be easy to dismiss and not reappear after dismissal (Primer feature onboarding); GitHub's dashboard made its onboarding module dismissible (changelog); onboarding help should stay findable after it is skipped (NN/g) and be closed with a visible control (NN/g).
Plan and review record:
devlog/_plan/261121_desktop_getting_started_hide/000_plan.md.Screenshots
Captured from a local
bun run src/cli/index.ts startwith an isolatedHOME,CODEX_HOMEandOPENCODEX_HOMEand one seeded provider. Desktop-shell views use the app's user agent (OpenCodexDesktop/2.100.6) in headless Chrome. The isolated proxy is not run by the app, so its "before" step 3 reads "Start automatically"; under the installed app the same row reads "Turn on Start at Login".Verification
Exact head
8610e9afc2on based61cca122dunless noted.gui/tests/home-getting-started.test.tsxon unchanged source: 7 fail, 1 pass (the browser case, which guards unchanged behavior). The review round added two storage cases that failed (2 fail, 10 pass) before the store fix.cd gui && bun ../scripts/test-with-pinned-bun.ts --isolate tests/home-getting-started.test.tsx tests/startup-checklist-desktop.test.tsx tests/startup-checklist-refresh.test.tsx tests/home-errors.test.tsx tests/home-management-health.test.tsx tests/i18n-locales.test.ts tests/locale-parity.test.ts: 65 pass, 0 fail.cd gui && bun run test(full GUI suite): 4760 pass, 0 fail, 442 files.bun run test:changed: 285 pass, 0 fail, 18 files.bun run test -- tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts: 38 pass (on5c4fee90c5; the later commit touches only the store, its test and the plan).bun run typecheck,bun run lint:gui,cd gui && bun run lint:i18n,bun run build:gui: all exit 0.bun run structure:checkandbun run privacy:scanpass (on5c4fee90c5);cd docs-site && bun run build: 820 pages, internal links checked, exit 0.NOT RUN to completion: full root
bun run test. On this host, shared with two sibling lanes (load average 24 on 18 cores), it hit the runner's 900 s limit (exit 124) with 17 timeout-class failures and unvisited files. Re-running the 13 failing files alone gave 364 pass, 10 fail: nine 5 s+ timeouts in CI scripts, catalog sync, messaging and PID-record tests, plus one combo fallback whose second target timed out at 405 ms. This branch changes onlygui/, one docs page and the devlog plan, so none of those root tests import changed code (test:changedresolves 18 affected files, all passing). Full Ubuntu shards are left to CI and the batcheddevrun.Checklist
Summary by CodeRabbit