Skip to content

feat(gui): drop Start at Login from the desktop Getting started and let Home hide it - #9007

Merged
lidge-jun merged 2 commits into
devfrom
codex/fb2100-home-checklist
Nov 20, 2026
Merged

lidge-jun merged 2 commits into
devfrom
codex/fb2100-home-checklist

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

Inside the OpenCodex desktop app, Home → Getting started read "2 of 3 done" and kept asking for Turn on Start at Login, even though the app's install and first launch already turn Start at Login on (desktop/src-tauri/src/first_run.rs). The card also could not be put away once someone was done with it.

  • Desktop app: Home and the Set up hub (Route → Checklist) drop the Start at Login step when the dashboard runs in the desktop shell (isDesktopShell()). Home now reads "X of 2" and the Checklist "X of 3". The browser dashboard keeps its step exactly as before, including the Desktop wording it shows when the app runs the proxy.
  • Hide: the Getting started card gets a Hide control (accessible name "Hide Getting started"). The choice is stored in localStorage (ocx-home-getting-started-hidden), so it is remembered per browser profile, and the app's window keeps its own. Only that card goes away; the stat tiles, the profile card and Recent errors stay, and Recent errors takes the full row. Right after hiding, a one-line note says where to bring it back, with Undo; keyboard focus moves to Undo, and back to Hide after Undo.
  • Restore: while the card is hidden, the Checklist shows "Getting started is hidden on Home." with Show on Home. The note on Home names that place from the live navigation labels ("Route → Checklist"), because the Set up hub is that tab rather than a sidebar item.
  • If storage refuses a read or a write, the choice still holds for the visit. Only events from this localStorage reconcile it across windows, so a sessionStorage clear elsewhere cannot undo an unsaved choice.
  • Copy for all 11 locales lives in gui/src/i18n/getting-started-copy.ts and is spread through shellV2Copy(), so no locale catalog changed. The English desktop guide describes the in-app checklist and how to hide and restore it; translated guides never described the checklist, so nothing there contradicts it.

Start at Login detection (src/service/desktop-startup.ts) and the Startup page are unchanged.

Prior art for the hide-and-restore pattern: dismissible checklists say "Hide" rather than "Close" and keep a permanent way back (saasui.design); onboarding should be easy to dismiss and not reappear after dismissal (Primer feature onboarding); GitHub's dashboard made its onboarding module dismissible (changelog); onboarding help should stay findable after it is skipped (NN/g) and be closed with a visible control (NN/g).

Plan and review record: devlog/_plan/261121_desktop_getting_started_hide/000_plan.md.

Screenshots

Captured from a local bun run src/cli/index.ts start with an isolated HOME, CODEX_HOME and OPENCODEX_HOME and one seeded provider. Desktop-shell views use the app's user agent (OpenCodexDesktop/2.100.6) in headless Chrome. The isolated proxy is not run by the app, so its "before" step 3 reads "Start automatically"; under the installed app the same row reads "Turn on Start at Login".

Before After
Desktop app, Home desktop home before desktop home after
Desktop app, Route → Checklist desktop checklist before desktop checklist after
Browser, Home (step kept, Hide added) browser home before browser home after
Right after Hide (GOAT browser) Hidden on a later visit Restore from Route → Checklist
home undo home hidden checklist show on home

Verification

Exact head 8610e9afc2 on base d61cca122d unless noted.

  • Failing first: gui/tests/home-getting-started.test.tsx on unchanged source: 7 fail, 1 pass (the browser case, which guards unchanged behavior). The review round added two storage cases that failed (2 fail, 10 pass) before the store fix.
  • cd gui && bun ../scripts/test-with-pinned-bun.ts --isolate tests/home-getting-started.test.tsx tests/startup-checklist-desktop.test.tsx tests/startup-checklist-refresh.test.tsx tests/home-errors.test.tsx tests/home-management-health.test.tsx tests/i18n-locales.test.ts tests/locale-parity.test.ts: 65 pass, 0 fail.
  • cd gui && bun run test (full GUI suite): 4760 pass, 0 fail, 442 files.
  • bun run test:changed: 285 pass, 0 fail, 18 files.
  • bun run test -- tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts: 38 pass (on 5c4fee90c5; the later commit touches only the store, its test and the plan).
  • bun run typecheck, bun run lint:gui, cd gui && bun run lint:i18n, bun run build:gui: all exit 0.
  • bun run structure:check and bun run privacy:scan pass (on 5c4fee90c5); cd docs-site && bun run build: 820 pages, internal links checked, exit 0.
  • Real browser: in GOAT's browser on the isolated proxy, Hide → note with Undo focused → Route → Checklist → Show on Home → "Getting started is back on Home." → the card is back on Home.
  • Independent review: gpt-6.1-terra plan audit (NEAR-PASS, 4 findings folded) and code review by the same reviewer (NEAR-PASS; the storage read-failure and sessionStorage-event findings are fixed with regression tests).
    NOT RUN to completion: full root bun run test. On this host, shared with two sibling lanes (load average 24 on 18 cores), it hit the runner's 900 s limit (exit 124) with 17 timeout-class failures and unvisited files. Re-running the 13 failing files alone gave 364 pass, 10 fail: nine 5 s+ timeouts in CI scripts, catalog sync, messaging and PID-record tests, plus one combo fallback whose second target timed out at 405 ms. This branch changes only gui/, one docs page and the devlog plan, so none of those root tests import changed code (test:changed resolves 18 affected files, all passing). Full Ubuntu shards are left to CI and the batched dev run.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • New Features
    • Desktop Home omits the Start at Login checklist step; the browser dashboard retains it.
    • Hide the Getting started checklist from Home, undo a recent hide, or restore it from the Set up hub. Your choice is remembered per browser profile and app window.
  • Documentation
    • Updated the desktop app guide to explain the checklist differences and how to hide or restore it.

…e hide Getting started

Inside the OpenCodex desktop app, the app's install and first run already turn
Start at Login on, so Home and the Set up hub no longer list that step there
(Home reads "X of 2"). The browser dashboard keeps its step unchanged.

Home's Getting started card gains a Hide control, remembered per browser
profile in localStorage; Recent errors and the other Home cards stay. Hiding
offers Undo for that visit, and the Set up hub brings the card back with
Show on Home. Copy for all 11 locales lives in getting-started-copy.ts.
Writable but unreadable storage made Hide revert on the next read; the store now
answers with the last choice made in this window. Only localStorage events
reconcile the choice, so a sessionStorage clear elsewhere cannot drop an
unsaved one. The Set up hub test asserts where focus lands after Show on Home.
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 20, 2026 18:20
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T18:22:29.004097Z 8610e9a PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the enhancement New feature or request label Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The desktop shell omits Start at Login from the Getting started checklist. Home can hide the checklist, and SetupHub can restore it. The hidden choice is stored in localStorage. The browser dashboard retains its Start at Login step.

Changes: Desktop Getting started checklist

Layer / File(s) Summary
Visibility state and localized copy
gui/src/getting-started-visibility.ts, gui/src/i18n/getting-started-copy.ts, gui/src/i18n/shell-v2-copy.ts
A shared visibility store persists the hidden choice, notifies subscribers, and handles relevant storage events. Localized hide and restore copy is included in the shell translations.
Checklist controls and validation
gui/src/pages/Home.tsx, gui/src/pages/SetupHub.tsx, gui/tests/home-getting-started.test.tsx, docs-site/src/content/docs/guides/desktop-app.md, devlog/_plan/261121_desktop_getting_started_hide/000_plan.md
Home and SetupHub omit Start at Login in the desktop shell. Home adds hide and undo controls; SetupHub adds a restore control. Tests cover browser and desktop behavior, persistence, storage events, focus, and storage failures. The guide and plan describe the changes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant Home
  participant VisibilityStore
  participant localStorage
  participant SetupHub
  Home->>VisibilityStore: hide checklist
  VisibilityStore->>localStorage: store hidden choice
  VisibilityStore-->>Home: notify subscribers
  SetupHub->>VisibilityStore: show checklist
  VisibilityStore->>localStorage: remove hidden choice
  VisibilityStore-->>Home: notify subscribers
Loading

Possibly related PRs

Suggested labels: enhancement

Merge Risk: Minimal · up to 8610e

The desktop Getting started checklist drops the Start at Login step and gains a hide and restore control stored per browser profile. No concrete merge-blocking risk was found, and the change is easy to revert.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two main changes: removing Start at Login from the desktop Getting started checklist, and letting Home hide the card. The changeset matches both: Home and SetupHub omit the autosta…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main changes: removing Start at Login from the desktop Getting started checklist, and letting Home hide the card. The changeset matches both: Home and SetupHub omit the autostart step in the desktop shell, and a new visibility store plus hide/show controls are added. The title is specific and follows conventional commit form. It is 84 characters, which is slightly long but acceptable.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between d61cca1 and 8610e9a.

Files selected for processing: 8

  • devlog/_plan/261121_desktop_getting_started_hide/000_plan.md
  • docs-site/src/content/docs/guides/desktop-app.md
  • gui/src/getting-started-visibility.ts
  • gui/src/i18n/getting-started-copy.ts
  • gui/src/i18n/shell-v2-copy.ts
  • gui/src/pages/Home.tsx
  • gui/src/pages/SetupHub.tsx
  • gui/tests/home-getting-started.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev (MAINTAINERS.md dev-only exception), recorded by the coordinator for @lidge-jun.

  • Exact head: 8610e9afc28eeff40ba1cd4fcb550928da3692dd; 20 checks passed, 12 skipped by PR policy (full shards, macOS, Windows; covered by the next batched dev dispatch).
  • Review: Codex review no findings; CodeRabbit no actionable comments; lane reviewer (gpt-6.1-terra, 2 rounds) findings fixed with regression tests. Coordinator checked that the hidden-state store guards the localStorage getter (currentStorage() try/catch) and that the browser dashboard keeps its Start at Login step.
  • Scope: GUI + English desktop guide + plan note; no auth, credential, workflow or release changes.
  • NOT RUN in lane: full root bun run test to completion (host contention), real desktop-app run (desktop shell simulated by UA).

@lidge-jun
lidge-jun merged commit 8bdd1ac into dev Nov 20, 2026
32 checks passed
@lidge-jun
lidge-jun deleted the codex/fb2100-home-checklist branch November 20, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant