Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
|
A second Windows x64 measurement separates the subprocess savings from the stop-recovery deadline. I combined this head ( In separate instrumented bound-restart runs, the disconnect phase issued 90 synchronous With the ordinary timeouts in place, bound restart and pending disconnect hit the 15 s parent limit in both configurations; the config-lock-contention rollback passed in both. This corroborates fewer permission-tool launches. The earlier 13.21 s pass in the description and today's results are individual runs; enabling the option does not consistently put the complete Windows recovery fixture under 15 s. |
|
Integration status from the current maintainer batch:
Because this changes private ACL hardening and |
Summary
Windows private file publication starts
icacls.exefor three permission changes on each new private entry. On a physical Windows host, updating a small Remote Link receipt spent about 0.32 s in six launches across its parent directory and temporary file.OPENCODEX_ACL_BATCH_RESTRICTIONS=1. The owner grant still has to succeed before the second command removes inherited permissions and the same broad explicit grants. The default stays off. Elevated staging continues to use its existing sequence.Verification
bun testontests/windows/{windows-acl-start-cost,windows-secret-acl,windows-secret-acl-diagnostics,windows-secret-acl-removal-flight,windows-atomic-write-acl-rearm,windows-lifecycle-root-acl}.test.tspassed all 288 cases with the option in the launching environment. The opt-in cases select it explicitly after test isolation. Typecheck, structure, privacy, and diff checks passed. The full local suite was not run; local coverage targeted the two execution paths, error metadata, publication, timeout handling and cleanup. Repository-wide coverage is left to CI.456946c5on the same physical Windows host and the same combined source tree: the stock bound-restart test completed in 13.21 s with the option enabled. With the option off, its existing 15 s parent watchdog fired at 15.06 s. Both runs used the original recovery assertions, child watchdog, and a fresh test home. This is one positive recovery case on one host.Checklist
Summary by CodeRabbit