Repository navigation
fix(link): verify recorded installations before probing - #8981
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
✅ Deterministic PR hygiene checks passed. |
|
Windows follow-up for |
|
Additional Windows evidence for I also located five of the locally failing test names in the existing Windows CI logs at |
The fixture home now uses its canonical path. macOS tmpdir sits below the /var symlink, which the trust gate resolves, so the stat stub keyed on the unresolved path never matched and two foreign-owner cases ran the binary. The trailing-newline symlink case runs on Linux only: BSD readlink omits the appended newline when a target already ends in one, which the Linux-only gate never meets. Ubuntu CI keeps exercising it.
|
Maintainer integration into
|
Summary
Verification
bun run typecheckchecked 2,682 files.bun run structure:check,bun run privacy:scan, andgit diff --checkpassed.687f8f4a, one unfiltered run of the five focused Remote Link files and both layout tests passed in an offline Windows x64 Sandbox under the signed-in guest user. Bun 1.4.4, Git for Windows 2.56.1, stock timeouts: 111 passed, 110 skipped, 0 failed, 781 assertions in 141.62 s. The pinned version-probe case completed in 39.62 s under its 60 s limit. The earlier physical-host run had 93 passes, 110 skips and 18 failures. The full repository suite was not run locally.687f8f4a, all 30 passed in Ubuntu shard 3/5. All five Ubuntu shards passed.f2d38e7dand based61cca12passed all four: recorded Bun/CLI discovery, served runtime version inspection, census lookup with a separate HOME, and Child precedence. These runs used fixture installations.f2d38e7d. With a diagnostic 45-second limit, both cases passed on that commit and on base. On687f8f4a, both passed under the normal runner in 3.12 s and 22.90 s. These two tests use the repository's 45-second subprocess budget with a 5-second teardown reserve. The exit, argv/stdin, and installation-order assertions are unchanged. Separate controls rejected a dropped argument and reversed installation order. A teardown check confirmed that the fixture is removed after a late child exits. Typecheck, privacy scan and diff checks passed locally.uv_spawn EPERMalone, the pinned version-probe test reported its 60-second runner timeout, and the native argv test reported both a launch denial and its then-current 5-second timeout. A focused run on the physical host at687f8f4aalso reportedEPERMstarting PowerShell in the pinned-sync and loopback HTTP success cases (1.26 s and 0.11 s). No endpoint block decision was established.6a4ae9d6: pinned sync, 1 case and discovery, 17 cases. Sixteen test bodies and the Windows script builder file are byte-identical between that run and687f8f4a. Two tests now use the updated subprocess deadline described above. The seven-file native Windows result above covers the current head. Maintainer security review remains outstanding.Checklist
Summary by CodeRabbit