Repository navigation
test(update): classify the managed-release launch-context read in the update lint - #8962
Conversation
… update lint #8911 made src/update/managed-release.ts import trustedManagedReleaseOptIn from ../cli/launcher-context. The update lint had no reviewed entry for that edge, so the Windows shards reported an unreviewed static dependency and a raw imported capability reference. The accessor only reads the launch context bound at startup.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Maintainer integration (lidge-jun, dev only) at head |
Summary
The Windows shards on
dev(62ffebbe90, ci lane=all run 44559432373,windows 9/14) fail both update-lint cases intests/update/update-mutation-guard.test.ts, at lines 22 and 51. #8911 madesrc/update/managed-release.tsimporttrustedManagedReleaseOptInfrom../cli/launcher-context. The update lint has no reviewed entry for that edge, so it reports an unreviewed static dependency (twice) and a raw imported capability reference.This PR adds the edge to the reviewed static-import table in
tests/helpers/update-import-policy.tsfor that one file and that exact import, with a comment explaining why. It is not a blanket allowlist.trustedManagedReleaseOptIn()only returnstrustedContext?.managedRelease === truefrom the launch context the Node launcher bound at startup. It opens no process, file or network capability and only decides which update guidance is shown. #8917 handled the earlier lint gap the same way.Verification
updateStaticImportsand is not a sensitive module skips capability-binding tracking (update-capability-policy.ts, the bindings loop) and passes thereason()admission. All three reported lines come from that one import statement and its single use.bun run typecheck: 2,666 files, no errors.bun run structure:checkand the file-size ratchet pass.tests/helpers/update-lint-parser.ts). They run only on the Windows shards, so the Windows confirmation comes from the nextdevbatch.devbatch), full local suite.Checklist
Summary by CodeRabbit