You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed a few small typos, documentation inconsistencies, and formatting issues.
These are all minor cleanup items, but fixing them would improve consistency and readability:
ltc_pkcs_1_pss_encode_mgf1.c:72: remove the unnecessary blank line
hmac_init.c:67: remove extra spaces
hash_memory.c: hash_descriptor[hash].hashsize is accessed multiple times. It could be stored in a local variable (like in hmac_done.c) after validating the hash, and then reused throughout the function:
der_decode_choice.c:111+112: align the calculation lines
der_decode_integer.c:75: remove the unnecessary blank line
der_decode_short_integer.c:62: remove the unnecessary blank line
der_decode_utctime.c:74-81: align the comment
der_decode_generalizedtime.c:91-98: align the comment
s_der_decode_sequence_flexi.c: The XMALLOC, XCALLOC and XREALLOC calls use a code style that differs from the rest of the codebase. I would prefer to write them as separate assignment and NULL-check statements, for example:
Activity
karel-m commentedon Aug 31, 2026
I am not sure about changing "separate assignment + NULL-check" the rest is fixed in #800
fix libtom#799 - minor formatting issues